Re: API review request / HttpException subclass of IOException

2008-05-28 Thread Ortwin Glück
Sam Berlin wrote: What are people's feelings on the HttpMethod constructors that throw a URISyntaxException? ... I hate RuntimeExceptions as much as the next guy, but what do you think of wrapping the exception in an IllegalArgumentException? It's very clear that it's an illegal argument. URI

RE: API review request / HttpException subclass of IOException

2008-05-27 Thread Sam Berlin
>Go ahead and make changes you deem necessary. Probably opening a JIRA >and attaching a patch for review would be a prudent way forward. >Meanwhile I'll try my best to make sure you get your commit rights in >time. If I fail to get hold of Erik, I'll send the account request >myself. Willdo, and

RE: API review request / HttpException subclass of IOException

2008-05-27 Thread Oleg Kalnichevski
---Original Message- > From: Oleg Kalnichevski [mailto:[EMAIL PROTECTED] > Sent: Tuesday, May 27, 2008 2:52 PM > To: HttpComponents Project > Subject: Re: API review request / HttpException subclass of IOException > > Sam, > > The trouble is that process of consuming

Re: API review request / HttpException subclass of IOException

2008-05-27 Thread peter royal
On May 27, 2008, at 12:09 PM, Sam Berlin wrote: But for people just wanting to execute an http request... if it screwed up, it screwed up. If you really need or want to know why it screwed up, you can dive into it from the exception's cause. +1 from the peanut gallery :) -pete -- [EMAIL P

RE: API review request / HttpException subclass of IOException

2008-05-27 Thread Sam Berlin
[mailto:[EMAIL PROTECTED] Sent: Tuesday, May 27, 2008 2:52 PM To: HttpComponents Project Subject: Re: API review request / HttpException subclass of IOException Sam, The trouble is that process of consuming HTTP response content can always result in an I/O exception. For real life applications w

Re: API review request / HttpException subclass of IOException

2008-05-27 Thread Oleg Kalnichevski
On Mon, 2008-05-26 at 20:00 -0400, Sam Berlin wrote: > >Exception handling is one of those. We cannot make everyone happy. > > I think in this case it might actually be possible to appease most > people. I agree with Oleg that the separation between HttpException & > IOException is useful, especi