Re: File based HTTP cache implementation is feature complete

2010-08-16 Thread Campbell, Joseph
2010 Subject: RE: File based HTTP cache implementation is feature complete Just an update here. I've done some scratch refactoring, and see how to do this now. I'm not quite done but am perhaps halfway there. The main issue here is that there is a "hidden class" inside Cachi

RE: File based HTTP cache implementation is feature complete

2010-08-16 Thread Oleg Kalnichevski
On Mon, 2010-08-16 at 16:36 -0400, Moore, Jonathan wrote: > Just an update here. I've done some scratch refactoring, and see how to > do this now. I'm not quite done but am perhaps halfway there. > > The main issue here is that there is a "hidden class" inside > CachingHttpClient that handles reso

RE: File based HTTP cache implementation is feature complete

2010-08-16 Thread Moore, Jonathan
implify CachingHttpClient and nicely encapsulate resource management and CacheEntry storage together behind the HttpCache interface. Jon -Original Message- From: Oleg Kalnichevski [mailto:ol...@apache.org] Sent: Friday, August 13, 2010 3:39 PM To: HttpComponents Project Subject:

RE: File based HTTP cache implementation is feature complete

2010-08-13 Thread Oleg Kalnichevski
On Fri, 2010-08-13 at 11:28 -0400, Moore, Jonathan wrote: > Hi Oleg, > > I took a quick look, and see where you are going with this. My only > suggestion here is that I'm not sure that an HttpCache and a > ResourceFactory should both be constructors to the CachingHttpClient; > this feels to me lik

RE: File based HTTP cache implementation is feature complete

2010-08-13 Thread Moore, Jonathan
Hi Oleg, I took a quick look, and see where you are going with this. My only suggestion here is that I'm not sure that an HttpCache and a ResourceFactory should both be constructors to the CachingHttpClient; this feels to me like the CachingHttpClient is getting a little too deep into the details