Zhen Zhang created HELIX-380:
Summary: Incompatibility issue with HELIX_PROPERTYSTORE
Key: HELIX-380
URL: https://issues.apache.org/jira/browse/HELIX-380
Project: Apache Helix
Issue Type: Bug
Yeah I was referring to the former case. It looks like they took the PR as a
patch, applied it to the ASF repo, and added "(closes #num)" to the commit
message.
It definitely makes sense that a PR not accepted and committed requires
originator action.
>
Are the PR merged to the repo? If the PR merged to the ASF git repo
then once the mirror github is sync it will automatically closed.
I was referring to the PRs that are not merged or somehow solved
differently. Then the original authors need to close them.
- Henry
On Wed, Feb 12, 2014 at 2:36 P
Henry,
I've seen other ASF projects be able to use a bot to close the pull request by
putting "closes #PRNUM" in the commit log. Does that still apply, or is it
something else set up by those projects?
Thanks,
Kanak
> Date: Wed, 12 Feb 2014 14:10:07 -0800
> Subject: Re: Apache git and github i
The only limitation is that the committers still need to merge
manually to ASF Git repo instead of the mirror github repo.
And it needs to maintain the actual comment and author of the commits
from the original PR for "karma" recording =)
And also if any pull request is not accepted or need update
+1
However, are there any negatives we aren't considering? I can't think of any.
- Bob
+1 for better GitHub integration.
Date: Tue, 11 Feb 2014 17:31:03 -0800
Subject: Apache git and github integration
From: g.kish...@gmail.com
To: dev@helix.apache.org; u...@helix.apache.org
Hi Guys,
We ca
+1
On 12 February 2014 12:31, kishore g wrote:
> Hi Guys,
>
> We can have much tighter integration between github and apache git.
>
> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>
> Should we opt in?
>
> thanks,
> Kishore G
--
Olivier Lamy
Ecetera: http://ecet
