Review Request 38170: De-couple IPC host / instance name

2015-09-07 Thread Greg Brandt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38170/ --- Review request for helix. Repository: helix-git Description ---

[GitHub] helix pull request: Added new DataSource values LIVEINSTANCES and ...

2015-09-07 Thread liyinan926
Github user liyinan926 commented on the pull request: https://github.com/apache/helix/pull/34#issuecomment-138434746 @kanakb @zzhang5 can one of you take a look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] helix pull request: Added new DataSource values LIVEINSTANCES and ...

2015-09-07 Thread kishoreg
Github user kishoreg commented on the pull request: https://github.com/apache/helix/pull/34#issuecomment-138435680 Looks good, can you add a simple test case? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your