Re: A possible leak of ZkClient object in helix?

2015-10-21 Thread kishore g
Hi Subbu, Can you show the jmap output that showed that the number of zkclients increased. Jason, simulating this is straight forward. - start ZK - set up a dummy cluster - start a dummy server/broker and controller - create a resource - stop ZKServer and restart it after setting jute.maxBuffer

Re: A possible leak of ZkClient object in helix?

2015-10-21 Thread Zhen Zhang
Hi Subbu, I don't think it's ZkClient leak. Each ZkClient has a ZkEventThread inside: https://github.com/sgroschupf/zkclient/blob/master/src/main/java/org/I0Itec/zkclient/ZkClient.java#L70 The ZkEventThread has a unique id: https://github.com/sgroschupf/zkclient/blob/master/src/main/java/org/I0It

A possible leak of ZkClient object in helix?

2015-10-21 Thread Subbu Subramaniam
Hi, We are using helix-0.6.5.22 version of helix for pinot development ( https://github.com/linkedin/pinot) The pinot controller constructs a ZkHelixPropertyStore() and adds a listener to listen to changes on all nodes under the path specified. If the zookeeper server is restarted, then the con