Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/41#issuecomment-182482218
Will review this today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/41#issuecomment-182487167
Looks good, please try to split the changes into smaller RB's. Its very
hard to review such a big RB. Can you address the RB comments. I will merge it
---
If your
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/41#discussion_r52488945
--- Diff:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java.rej
---
@@ -0,0 +1,18 @@
+diff
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/41#discussion_r52489589
--- Diff: helix-core/src/main/java/org/apache/helix/task/JobRebalancer.java
---
@@ -206,9 +205,23 @@ private ResourceAssignment
computeResourceMapping(String
Github user lei-xia commented on the pull request:
https://github.com/apache/helix/pull/41#issuecomment-182658641
Thanks for reviewing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user lei-xia commented on a diff in the pull request:
https://github.com/apache/helix/pull/41#discussion_r52551298
--- Diff:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java.rej
---
@@ -0,0 +1,18 @@
+diff
