[jira] [Commented] (HELIX-651) Add a method in HelixAdmin to set the InstanceConfig of an existing instance

2017-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813637#comment-15813637 ] ASF GitHub Bot commented on HELIX-651: -- Github user pnarayanan commented on the issue:

[GitHub] helix issue #65: [HELIX-651] Add a method in HelixAdmin to set the InstanceC...

2017-01-09 Thread pnarayanan
Github user pnarayanan commented on the issue: https://github.com/apache/helix/pull/65 Updated PR to address comments. @dasahcc will sync up with you about the API. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] helix pull request #65: [HELIX-651] Add a method in HelixAdmin to set the In...

2017-01-09 Thread pnarayanan
Github user pnarayanan commented on a diff in the pull request: https://github.com/apache/helix/pull/65#discussion_r95283527 --- Diff: helix-core/src/main/java/org/apache/helix/HelixAdmin.java --- @@ -51,6 +51,16 @@ InstanceConfig getInstanceConfig(String clusterName, String

[jira] [Commented] (HELIX-651) Add a method in HelixAdmin to set the InstanceConfig of an existing instance

2017-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813448#comment-15813448 ] ASF GitHub Bot commented on HELIX-651: -- Github user pnarayanan commented on a diff in the pull

[jira] [Commented] (HELIX-651) Add a method in HelixAdmin to set the InstanceConfig of an existing instance

2017-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813429#comment-15813429 ] ASF GitHub Bot commented on HELIX-651: -- Github user pnarayanan commented on a diff in the pull

[GitHub] helix pull request #65: [HELIX-651] Add a method in HelixAdmin to set the In...

2017-01-09 Thread pnarayanan
Github user pnarayanan commented on a diff in the pull request: https://github.com/apache/helix/pull/65#discussion_r95282358 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java --- @@ -162,6 +162,20 @@ public InstanceConfig getInstanceConfig(String

[jira] [Commented] (HELIX-651) Add a method in HelixAdmin to set the InstanceConfig of an existing instance

2017-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813426#comment-15813426 ] ASF GitHub Bot commented on HELIX-651: -- Github user dasahcc commented on a diff in the pull request:

[jira] [Commented] (HELIX-651) Add a method in HelixAdmin to set the InstanceConfig of an existing instance

2017-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813427#comment-15813427 ] ASF GitHub Bot commented on HELIX-651: -- Github user dasahcc commented on a diff in the pull request:

[jira] [Commented] (HELIX-651) Add a method in HelixAdmin to set the InstanceConfig of an existing instance

2017-01-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813420#comment-15813420 ] ASF GitHub Bot commented on HELIX-651: -- Github user kishoreg commented on a diff in the pull request:

[GitHub] helix pull request #65: [HELIX-651] Add a method in HelixAdmin to set the In...

2017-01-09 Thread dasahcc
Github user dasahcc commented on a diff in the pull request: https://github.com/apache/helix/pull/65#discussion_r95282190 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java --- @@ -162,6 +162,20 @@ public InstanceConfig getInstanceConfig(String

[GitHub] helix pull request #65: [HELIX-651] Add a method in HelixAdmin to set the In...

2017-01-09 Thread dasahcc
Github user dasahcc commented on a diff in the pull request: https://github.com/apache/helix/pull/65#discussion_r95282053 --- Diff: helix-core/src/main/java/org/apache/helix/HelixAdmin.java --- @@ -51,6 +51,16 @@ InstanceConfig getInstanceConfig(String clusterName, String

[GitHub] helix pull request #65: [HELIX-651] Add a method in HelixAdmin to set the In...

2017-01-09 Thread kishoreg
Github user kishoreg commented on a diff in the pull request: https://github.com/apache/helix/pull/65#discussion_r95282034 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java --- @@ -162,6 +162,20 @@ public InstanceConfig getInstanceConfig(String

[GitHub] helix pull request #65: [HELIX-651] Add a method in HelixAdmin to set the In...

2017-01-09 Thread kishoreg
Github user kishoreg commented on a diff in the pull request: https://github.com/apache/helix/pull/65#discussion_r95281496 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java --- @@ -162,6 +162,20 @@ public InstanceConfig getInstanceConfig(String

[jira] [Commented] (HELIX-651) Add a method in HelixAdmin to set the InstanceConfig of an existing instance

2017-01-09 Thread kishore gopalakrishna (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813408#comment-15813408 ] kishore gopalakrishna commented on HELIX-651: - +1 on adding explicit setInstanceConfig method.

[GitHub] helix pull request #65: [HELIX-651] Add a method in HelixAdmin to set the In...

2017-01-09 Thread pnarayanan
GitHub user pnarayanan opened a pull request: https://github.com/apache/helix/pull/65 [HELIX-651] Add a method in HelixAdmin to set the InstanceConfig - Add a setInstanceConfig() method in HelixAdmin interface - Add an implementation for the same in ZkHelixAdmin - Add a test

[jira] [Created] (HELIX-651) Add a method in HelixAdmin to set the InstanceConfig of an existing instance

2017-01-09 Thread Priyesh (JIRA)
Priyesh created HELIX-651: - Summary: Add a method in HelixAdmin to set the InstanceConfig of an existing instance Key: HELIX-651 URL: https://issues.apache.org/jira/browse/HELIX-651 Project: Apache Helix