[
https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813637#comment-15813637
]
ASF GitHub Bot commented on HELIX-651:
--
Github user pnarayanan commented on the issue:
Github user pnarayanan commented on the issue:
https://github.com/apache/helix/pull/65
Updated PR to address comments. @dasahcc will sync up with you about the
API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user pnarayanan commented on a diff in the pull request:
https://github.com/apache/helix/pull/65#discussion_r95283527
--- Diff: helix-core/src/main/java/org/apache/helix/HelixAdmin.java ---
@@ -51,6 +51,16 @@
InstanceConfig getInstanceConfig(String clusterName, String
[
https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813448#comment-15813448
]
ASF GitHub Bot commented on HELIX-651:
--
Github user pnarayanan commented on a diff in the pull
[
https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813429#comment-15813429
]
ASF GitHub Bot commented on HELIX-651:
--
Github user pnarayanan commented on a diff in the pull
Github user pnarayanan commented on a diff in the pull request:
https://github.com/apache/helix/pull/65#discussion_r95282358
--- Diff:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java ---
@@ -162,6 +162,20 @@ public InstanceConfig getInstanceConfig(String
[
https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813426#comment-15813426
]
ASF GitHub Bot commented on HELIX-651:
--
Github user dasahcc commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813427#comment-15813427
]
ASF GitHub Bot commented on HELIX-651:
--
Github user dasahcc commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813420#comment-15813420
]
ASF GitHub Bot commented on HELIX-651:
--
Github user kishoreg commented on a diff in the pull request:
Github user dasahcc commented on a diff in the pull request:
https://github.com/apache/helix/pull/65#discussion_r95282190
--- Diff:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java ---
@@ -162,6 +162,20 @@ public InstanceConfig getInstanceConfig(String
Github user dasahcc commented on a diff in the pull request:
https://github.com/apache/helix/pull/65#discussion_r95282053
--- Diff: helix-core/src/main/java/org/apache/helix/HelixAdmin.java ---
@@ -51,6 +51,16 @@
InstanceConfig getInstanceConfig(String clusterName, String
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/65#discussion_r95282034
--- Diff:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java ---
@@ -162,6 +162,20 @@ public InstanceConfig getInstanceConfig(String
Github user kishoreg commented on a diff in the pull request:
https://github.com/apache/helix/pull/65#discussion_r95281496
--- Diff:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java ---
@@ -162,6 +162,20 @@ public InstanceConfig getInstanceConfig(String
[
https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813408#comment-15813408
]
kishore gopalakrishna commented on HELIX-651:
-
+1 on adding explicit setInstanceConfig method.
GitHub user pnarayanan opened a pull request:
https://github.com/apache/helix/pull/65
[HELIX-651] Add a method in HelixAdmin to set the InstanceConfig
- Add a setInstanceConfig() method in HelixAdmin interface
- Add an implementation for the same in ZkHelixAdmin
- Add a test
Priyesh created HELIX-651:
-
Summary: Add a method in HelixAdmin to set the InstanceConfig of
an existing instance
Key: HELIX-651
URL: https://issues.apache.org/jira/browse/HELIX-651
Project: Apache Helix
16 matches
Mail list logo