Github user pnarayanan commented on the issue:
https://github.com/apache/helix/pull/65
thanks - should I create a PR for master as well? What is the usual flow?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pnarayanan commented on the issue:
https://github.com/apache/helix/pull/65
Done.
(Just FYI: github allows a squash-and-merge option that lets the reviewer
merge the whole patch as a single commit - in case you want to use that flow in
the future).
---
If your
Github user pnarayanan commented on the issue:
https://github.com/apache/helix/pull/65
Updated PR to address comments. @dasahcc will sync up with you about the
API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user pnarayanan commented on a diff in the pull request:
https://github.com/apache/helix/pull/65#discussion_r95283527
--- Diff: helix-core/src/main/java/org/apache/helix/HelixAdmin.java ---
@@ -51,6 +51,16 @@
InstanceConfig getInstanceConfig(String clusterName, String
Github user pnarayanan commented on a diff in the pull request:
https://github.com/apache/helix/pull/65#discussion_r95282358
--- Diff:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java ---
@@ -162,6 +162,20 @@ public InstanceConfig getInstanceConfig(String
GitHub user pnarayanan opened a pull request:
https://github.com/apache/helix/pull/65
[HELIX-651] Add a method in HelixAdmin to set the InstanceConfig
- Add a setInstanceConfig() method in HelixAdmin interface
- Add an implementation for the same in ZkHelixAdmin
- Add a test
