Github user asfgit closed the pull request at:
https://github.com/apache/helix/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liyinan926 commented on the pull request:
https://github.com/apache/helix/pull/35#issuecomment-139339504
@kishoreg Can you take a look at this PR again? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user liyinan926 commented on the pull request:
https://github.com/apache/helix/pull/35#issuecomment-138976620
@kishoreg I do have a reference to a `TaskStateModelFactory` instance, but
I don't have reference to any `TaskStateModel` instances created by it though
so I cannot
Github user liyinan926 commented on the pull request:
https://github.com/apache/helix/pull/35#issuecomment-139021356
@kishoreg Yes, I was actually looking at `StateTransitionHandlerFactory`
and I thought about doing that. The problem is `shutdown` is specific to
`TaskStateModel` but
Github user liyinan926 commented on the pull request:
https://github.com/apache/helix/pull/35#issuecomment-139025101
@kishoreg Updated 6ae7891.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kishoreg commented on the pull request:
https://github.com/apache/helix/pull/35#issuecomment-138792278
This is an interesting change, why cant we do this on the client side? If
you have the reference to StateModelFactory, you can call the shutdown method
on each and every
