[GitHub] helix pull request: [HELIX-613] Fix thread leaking problems in Tas...

2015-11-08 Thread lei-xia
Github user lei-xia commented on the pull request: https://github.com/apache/helix/pull/38#issuecomment-154924074 It is little bit tricky to add unit test to verify there is no leaking, also it takes some time to generate and detect leaking, which makes the unit tests takes even

[GitHub] helix pull request: [HELIX-613] Fix thread leaking problems in Tas...

2015-11-08 Thread kanakb
Github user kanakb commented on the pull request: https://github.com/apache/helix/pull/38#issuecomment-154940124 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] helix pull request: [HELIX-613] Fix thread leaking problems in Tas...

2015-11-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/helix/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] helix pull request: [HELIX-613] Fix thread leaking problems in Tas...

2015-11-07 Thread lei-xia
GitHub user lei-xia opened a pull request: https://github.com/apache/helix/pull/38 [HELIX-613] Fix thread leaking problems in TaskStateModel. Current TaskStateModel creates a thread-pool containing 40 threads for each instance of TaskStateModel, thus it creates 40 threads for each

[GitHub] helix pull request: [HELIX-613] Fix thread leaking problems in Tas...

2015-11-07 Thread kishoreg
Github user kishoreg commented on the pull request: https://github.com/apache/helix/pull/38#issuecomment-154778932 LGTM. Any test case to ensure that there is no leak? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If