[GitHub] helix pull request: [Helix-606] Add an option in IdealState to all...

2015-07-28 Thread kanakb
Github user kanakb commented on the pull request: https://github.com/apache/helix/pull/32#issuecomment-125824325 Could you fix the merge conflicts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] helix pull request: [Helix-606] Add an option in IdealState to all...

2015-07-28 Thread lei-xia
Github user lei-xia commented on the pull request: https://github.com/apache/helix/pull/32#issuecomment-125834788 Merged with head and solved the conflicts. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] helix pull request: [Helix-606] Add an option in IdealState to all...

2015-07-28 Thread kanakb
Github user kanakb commented on the pull request: https://github.com/apache/helix/pull/32#issuecomment-125834976 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] helix pull request: [Helix-606] Add an option in IdealState to all...

2015-07-28 Thread kishoreg
Github user kishoreg commented on a diff in the pull request: https://github.com/apache/helix/pull/32#discussion_r35688508 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java --- @@ -645,7 +645,7 @@ public boolean isLeader() { if