[GitHub] helix pull request #159: Improvements to Helix's Callback handling.

2018-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/helix/pull/159 ---

[GitHub] helix pull request #159: Improvements to Helix's Callback handling.

2018-03-27 Thread lei-xia
Github user lei-xia commented on a diff in the pull request: https://github.com/apache/helix/pull/159#discussion_r177537725 --- Diff: helix-core/src/main/java/org/apache/helix/common/DedupEventBlockingQueue.java --- @@ -0,0 +1,139 @@ +package org.apache.helix.common; +

[GitHub] helix pull request #159: Improvements to Helix's Callback handling.

2018-03-27 Thread lei-xia
Github user lei-xia commented on a diff in the pull request: https://github.com/apache/helix/pull/159#discussion_r177537463 --- Diff: helix-core/src/main/java/org/apache/helix/common/DedupEventBlockingQueue.java --- @@ -0,0 +1,139 @@ +package org.apache.helix.common; +

[GitHub] helix pull request #159: Improvements to Helix's Callback handling.

2018-03-27 Thread lei-xia
Github user lei-xia commented on a diff in the pull request: https://github.com/apache/helix/pull/159#discussion_r177534964 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java --- @@ -153,7 +195,12 @@ private void parseListenerProperties() {

[GitHub] helix pull request #159: Improvements to Helix's Callback handling.

2018-03-26 Thread kishoreg
Github user kishoreg commented on a diff in the pull request: https://github.com/apache/helix/pull/159#discussion_r177275969 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java --- @@ -257,18 +308,22 @@ public void run() { }

[GitHub] helix pull request #159: Improvements to Helix's Callback handling.

2018-03-26 Thread kishoreg
Github user kishoreg commented on a diff in the pull request: https://github.com/apache/helix/pull/159#discussion_r177260701 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java --- @@ -153,7 +195,12 @@ private void parseListenerProperties() {

[GitHub] helix pull request #159: Improvements to Helix's Callback handling.

2018-03-26 Thread kishoreg
Github user kishoreg commented on a diff in the pull request: https://github.com/apache/helix/pull/159#discussion_r177274948 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java --- @@ -168,41 +215,41 @@ private void parseListenerProperties() {

[GitHub] helix pull request #159: Improvements to Helix's Callback handling.

2018-03-26 Thread kishoreg
Github user kishoreg commented on a diff in the pull request: https://github.com/apache/helix/pull/159#discussion_r177257703 --- Diff: helix-core/src/main/java/org/apache/helix/common/DedupEventBlockingQueue.java --- @@ -0,0 +1,139 @@ +package org.apache.helix.common; +

[GitHub] helix pull request #159: Improvements to Helix's Callback handling.

2018-03-26 Thread kishoreg
Github user kishoreg commented on a diff in the pull request: https://github.com/apache/helix/pull/159#discussion_r177260018 --- Diff: helix-core/src/main/java/org/apache/helix/common/DedupEventBlockingQueue.java --- @@ -0,0 +1,139 @@ +package org.apache.helix.common; +

[GitHub] helix pull request #159: Improvements to Helix's Callback handling.

2018-03-24 Thread lei-xia
GitHub user lei-xia opened a pull request: https://github.com/apache/helix/pull/159 Improvements to Helix's Callback handling. - Improve CallbackHandler by avoiding unnessary re-subscripe to the data change event.Resubscribe to zk changes only when there is any child chanage, with