[GitHub] nlu90 commented on a change in pull request #2886: [wip] submit topology file by uri

2018-05-02 Thread GitBox
nlu90 commented on a change in pull request #2886: [wip] submit topology file by uri URL: https://github.com/apache/incubator-heron/pull/2886#discussion_r185703931 ## File path: heron/tools/cli/src/python/submit.py ## @@ -366,6 +368,16 @@ def submit_cpp(cl_args, unknown_ar

[GitHub] huijunwu opened a new pull request #2886: [wip] submit topology file by uri

2018-05-02 Thread GitBox
huijunwu opened a new pull request #2886: [wip] submit topology file by uri URL: https://github.com/apache/incubator-heron/pull/2886 replace #2274 after #2884 `$ heron submit [options] cluster/[role]/[env] topology-file-uri topology-class-name [topology-args]` for example:

[GitHub] kramasamy commented on issue #2879: remove thrift and scribe to prepare for apache release

2018-05-02 Thread GitBox
kramasamy commented on issue #2879: remove thrift and scribe to prepare for apache release URL: https://github.com/apache/incubator-heron/pull/2879#issuecomment-386197899 @nlu90 - done. updating the master. This is an automat

Re: Copyright Violations

2018-05-02 Thread Ning Wang
Agreed and thanks for the suggestions! On Wed, May 2, 2018 at 7:52 PM, P. Taylor Goetz wrote: > Thank you all for stepping up to correct this. > > With my mentor hat on... > > Trademark, licensing, and copyright hygiene are very important for ASF > projects. > > I’d encourage everyone to proacti

Re: Copyright Violations

2018-05-02 Thread P. Taylor Goetz
Thank you all for stepping up to correct this. With my mentor hat on... Trademark, licensing, and copyright hygiene are very important for ASF projects. I’d encourage everyone to proactively research branding, release, and other policies. ASF documentation can seem pretty scattered, but it is

[GitHub] nlu90 commented on issue #2884: move downloader registry map to yaml

2018-05-02 Thread GitBox
nlu90 commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-386154314 LGTM. Let's see if @kramasamy has any comments. This is an automated message

[GitHub] nlu90 commented on issue #2884: move downloader registry map to yaml

2018-05-02 Thread GitBox
nlu90 commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-386154314 LGTM This is an automated message from the Apache Git Service. To respond to

[GitHub] huijunwu commented on a change in pull request #2884: move downloader registry map to yaml

2018-05-02 Thread GitBox
huijunwu commented on a change in pull request #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#discussion_r185668816 ## File path: heron/downloaders/src/java/org/apache/heron/downloader/DownloadRunner.java ## @@ -38,7 +

[GitHub] huijunwu commented on a change in pull request #2884: move downloader registry map to yaml

2018-05-02 Thread GitBox
huijunwu commented on a change in pull request #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#discussion_r185668803 ## File path: heron/downloaders/src/java/org/apache/heron/downloader/DownloadRunner.java ## @@ -38,7 +

[GitHub] nlu90 commented on a change in pull request #2884: move downloader registry map to yaml

2018-05-02 Thread GitBox
nlu90 commented on a change in pull request #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#discussion_r185652663 ## File path: heron/downloaders/src/java/org/apache/heron/downloader/DownloadRunner.java ## @@ -38,7 +184

[GitHub] nlu90 commented on a change in pull request #2884: move downloader registry map to yaml

2018-05-02 Thread GitBox
nlu90 commented on a change in pull request #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#discussion_r185650554 ## File path: heron/downloaders/src/java/org/apache/heron/downloader/DownloadRunner.java ## @@ -38,7 +184

[GitHub] nwangtw opened a new pull request #2885: Update license text in H files

2018-05-02 Thread GitBox
nwangtw opened a new pull request #2885: Update license text in H files URL: https://github.com/apache/incubator-heron/pull/2885 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] tomncooper commented on issue #2877: Compilation error in a container

2018-05-02 Thread GitBox
tomncooper commented on issue #2877: Compilation error in a container URL: https://github.com/apache/incubator-heron/issues/2877#issuecomment-386131052 Have you checked out one of the release tags or are you building from the head of the master branch? Try checking out the latest tag, 0.17

[GitHub] comes5 commented on issue #2877: Compilation error in a container

2018-05-02 Thread GitBox
comes5 commented on issue #2877: Compilation error in a container URL: https://github.com/apache/incubator-heron/issues/2877#issuecomment-386130089 So, I am trying with virtualbox now, following the heron documentation with ubuntu 16.04. So far no errors from thrift and scribe, but the bui

[GitHub] huijunwu opened a new pull request #2884: move downloader registry map to yaml

2018-05-02 Thread GitBox
huijunwu opened a new pull request #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884 I am revisiting https://github.com/apache/incubator-heron/pull/2274. The static config in the downloader registry looks hard to extend in our private repo

[GitHub] nlu90 opened a new pull request #2883: check checkpoint file exists before deleting it

2018-05-02 Thread GitBox
nlu90 opened a new pull request #2883: check checkpoint file exists before deleting it URL: https://github.com/apache/incubator-heron/pull/2883 Currently, if there's no checkpoint file under the root dir, the LocalFileSystemStorage will raise an NPE directly and cause the process to stop

[GitHub] nlu90 closed pull request #2878: Update NOTICE file

2018-05-02 Thread GitBox
nlu90 closed pull request #2878: Update NOTICE file URL: https://github.com/apache/incubator-heron/pull/2878 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

Re: Copyright Violations

2018-05-02 Thread Ning Wang
Prepared two PRs to update license text so far: https://github.com/apache/incubator-heron/pull/2881 https://github.com/apache/incubator-heron/pull/2882 Other files to come. On Wed, May 2, 2018 at 10:40 AM, Karthik Ramasamy wrote: > Dave - > > Task that we are working are > > - Convert namespa

Re: Heron github emails

2018-05-02 Thread Eren Avsarogullari
+1 On Wed, May 2, 2018, 18:50 Neng Lu wrote: > +1 > > On Tue, May 1, 2018 at 7:41 PM, Jake Farrell wrote: > > > +1 > > > > -Jake > > > > On Tue, May 1, 2018 at 10:00 PM, Chris Kellogg > > wrote: > > > > > +1 > > > > > > On Tue, May 1, 2018 at 4:45 PM, Karthik Ramasamy > > > wrote: > > > > > >

Re: Heron github emails

2018-05-02 Thread Neng Lu
+1 On Tue, May 1, 2018 at 7:41 PM, Jake Farrell wrote: > +1 > > -Jake > > On Tue, May 1, 2018 at 10:00 PM, Chris Kellogg > wrote: > > > +1 > > > > On Tue, May 1, 2018 at 4:45 PM, Karthik Ramasamy > > wrote: > > > > > +1 as well. > > > > > > On Tue, May 1, 2018 at 3:53 PM Josh Fischer > wrote:

Re: Copyright Violations

2018-05-02 Thread Karthik Ramasamy
Dave - Task that we are working are - Convert namespace com.twitter.heron to org.apache.heron - completed - Copyright on the source files - ongoing - Binaries are being removed from the code base - ongoing Meetup last week was great. We had around 80 people attending and we had three talks. Anot

Re: Podling Report Reminder - May 2018

2018-05-02 Thread Josh Fischer
Thanks Jake, I've added the notes in the report about licensing header work. I've also marked you as signed off on the report. On Wed, May 2, 2018 at 11:40 AM, Jake Farrell wrote: > Thanks Josh, +1 > > Would mention the licensing header work also in progress, you can mark me > as signed off on

Re: Podling Report Reminder - May 2018

2018-05-02 Thread Jake Farrell
Thanks Josh, +1 Would mention the licensing header work also in progress, you can mark me as signed off on the report when you submit it on the incubator wiki -Jake On Wed, May 2, 2018 at 1:28 AM, Karthik Ramasamy wrote: > Josh - Looks good to me. > > > On May 1, 2018, at 2:44 PM, Josh Fischer

[GitHub] nlu90 commented on issue #2879: remove thrift and scribe to prepare for apache release

2018-05-02 Thread GitBox
nlu90 commented on issue #2879: remove thrift and scribe to prepare for apache release URL: https://github.com/apache/incubator-heron/pull/2879#issuecomment-386028654 Please also clean up the scribe and thrift test directory.

Re: Podling Report Reminder - May 2018

2018-05-02 Thread Josh Fischer
All, The official podling status report has been submitted. Let me know if you have any questions. On Wed, May 2, 2018 at 12:28 AM, Karthik Ramasamy wrote: > Josh - Looks good to me. > > > On May 1, 2018, at 2:44 PM, Josh Fischer wrote: > > > > Hi All, > > > > Please see below and feel free to

[GitHub] nwangtw opened a new pull request #2882: Update license text in cpp files

2018-05-02 Thread GitBox
nwangtw opened a new pull request #2882: Update license text in cpp files URL: https://github.com/apache/incubator-heron/pull/2882 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] kramasamy commented on issue #2877: Compilation error in a container

2018-05-02 Thread GitBox
kramasamy commented on issue #2877: Compilation error in a container URL: https://github.com/apache/incubator-heron/issues/2877#issuecomment-385885625 @comes5 - in the new PR #2879 - we are removing the scribe and the thrift executable. Once this is merged, this error will go away. --

[GitHub] nwangtw opened a new pull request #2881: Update license text in java files

2018-05-02 Thread GitBox
nwangtw opened a new pull request #2881: Update license text in java files URL: https://github.com/apache/incubator-heron/pull/2881 This is an automated message from the Apache Git Service. To respond to the message, please l