Nice. Thanks for finding this. It will definitely help. - Josh
On Thu, Feb 6, 2020 at 11:32 PM Ning Wang <wangnin...@gmail.com> wrote: > It seems like Debian has its own netcat replacement under BSD license. This > PR should solve the netcat license issue. > > https://github.com/apache/incubator-heron/pull/3447 > > On Wed, Feb 5, 2020 at 12:19 AM Ning Wang <wangnin...@gmail.com> wrote: > > > I don't think vim is needed in the dist container. netcat is used in a > few > > ZK related scripts checking if zk is running. > > > > On Tue, Feb 4, 2020 at 6:56 PM Josh Fischer <j...@joshfischer.io> wrote: > > > >> Hi All, > >> > >> After doing some research into the Debian container.. I've listed the > >> packages that are installed. I've also included links to licenses or > >> copyrights and my notes based on what I could find. > >> > >> Installed packages are: > >> > >> netcat > >> > >> vim > >> > >> python > >> > >> supervisor > >> > >> curl > >> > >> unzip > >> > >> > >> My notes below > >> > >> > >> - > >> > >> Netcat - GPL (Probably a no go) > >> - > >> > >> Vim - GPL (Probably a no go) > >> - > >> > >> Python - I think we are good here > >> - > >> > >> Supervisor > >> > >> > https://raw.githubusercontent.com/Supervisor/supervisor/master/COPYRIGHT.txt > >> (I’m not sure. The link in the file to the license is broken > >> - > >> > >> Curl - https://raw.githubusercontent.com/curl/curl/master/COPYING ( > I > >> think we are good) > >> - > >> > >> Unzip: http://infozip.sourceforge.net/license.html > >> > >> > >> - > >> > >> Notes from the page:::: It's basically BSD-like, but note that there > >> may > >> still be a few remaining files in some of the packages that are > >> covered by > >> different licenses. ( I think we are good?) > >> > >> > >> My assumption is that we will have to remove vim (no big deal) and > netcat > >> at least before we can create binaries and send out a vote. I'm not sure > >> about supervisor, curl, or unzip. Questions, comments, concerns? > >> > >> - Josh > >> > >> On Mon, Feb 3, 2020 at 5:55 PM Ning Wang <wangnin...@gmail.com> wrote: > >> > >> > Very helpful! > >> > > >> > On Mon, Feb 3, 2020 at 12:44 PM Dave Fisher <w...@apache.org> wrote: > >> > > >> > > Hi - > >> > > > >> > > Regarding OpenJDK and GPL2 - here is what Roman the VP, Legal wrote > >> when > >> > > answering Beam’s questions. > >> > > > >> > > Roman Shaposhnik commented on LEGAL-503: > >> > > ---------------------------------------- > >> > > > >> > > Hey [~altay] if you would like to continue linking to the Docker > >> release > >> > > artifact from the > >> > > https://beam.apache.org > >> > > you will have: > >> > > 1. Transition to the official ASF dockerhub org: > >> > > https://hub.docker.com/u/apache > >> > > 2. Start including that binary convenience artifact into your > VOTE > >> > > threads on Beam releases > >> > > 3. Make sure that all Cat-X licenses are ONLY brought into your > >> > > container via FROM statements > >> > > > >> > > Regards, > >> > > Dave > >> > > > >> > > > On Feb 3, 2020, at 12:34 PM, Josh Fischer <j...@joshfischer.io> > >> wrote: > >> > > > > >> > > > I think what Nick is talking about is Travis CI, not Jenkins. It > >> > seems > >> > > > that ubuntu LTS may have some issues with creating the container. > >> > This > >> > > > may put a lot of work ahead of us. My first thought is to use > >> Debian > >> > as > >> > > > the "official" Heron container for apache. It is built from the > >> > > > openjdk:8-jdk-slim docker image. I know that Tomcat uses a > >> > > > similar container from the openjdk org. It might be the path of > >> least > >> > > > resistance when it comes to making sure the licenses are ok. But > a > >> > > > possible hang up with the openjdk container is that is uses a GPL2 > >> > > license > >> > > > which is not compatible with Apache (this is my understanding). > So > >> I'm > >> > > > thinking of running the questions about the Debian container to > >> legal. > >> > > > Any thoughts? > >> > > > > >> > > > On Mon, Feb 3, 2020 at 12:48 PM Ning Wang <wangnin...@gmail.com> > >> > wrote: > >> > > > > >> > > >> I am fine with keeping the docker files. > >> > > >> > >> > > >> It is a good point that Jenkins machine is a factor. > >> > > >> > >> > > >> On Mon, Feb 3, 2020 at 9:27 AM Nicholas Nezis < > >> > nicholas.ne...@gmail.com > >> > > > > >> > > >> wrote: > >> > > >> > >> > > >>> Linux and MacOS installer definitely. For the MacOS users, it > >> would > >> > be > >> > > >>> awesome to maintain being able to `brew install heron` > >> > > >>> > >> > > >>> As to the images, I definitely think it would be better to keep > a > >> > > smaller > >> > > >>> set of Dockerfiles. With my move to Bazel 2.0 it has been > painful > >> > > working > >> > > >>> through the various build issues related to the different OS > >> builds. > >> > If > >> > > >> the > >> > > >>> Dockerfiles are meant to provide people with the list of > packages > >> for > >> > > >> their > >> > > >>> local install, perhaps maintaining them is ok. If the goal is to > >> have > >> > > an > >> > > >>> isolated build container and runtime container, then having a > >> single > >> > > >> option > >> > > >>> makes more sense. > >> > > >>> > >> > > >>> Short term: > >> > > >>> Ubuntu 14.04 is used in the Travis CI build so having them be > >> > > consistent > >> > > >>> makes sense to me. This is the image I would focus on. > >> > > >>> > >> > > >>> Long term: > >> > > >>> We should update things to use a newer Ubuntu LTS version if > >> > possible. > >> > > >>> There are some issues that might be blockers: > >> > > >>> - cppcheck doesn't compile on Ubuntu 18.04 ( > >> > > >>> https://github.com/apache/incubator-heron/issues/3440) > >> > > >>> - TravisCI expects JDK 9+ on Ubuntu 16+ > >> > > >>> - DNS issue with Ubuntu in Kubernetes ( > >> > > >>> > >> > > >>> > >> > > >> > >> > > > >> > > >> > https://kubernetes.io/docs/tasks/administer-cluster/dns-debugging-resolution/#known-issues > >> > > >>> ) > >> > > >>> > >> > > >>> > >> > > >>> On Mon, Feb 3, 2020 at 11:58 AM Ning Wang <wangnin...@gmail.com > > > >> > > wrote: > >> > > >>> > >> > > >>>> For installer, I feel that MacOS should be included. > >> > > >>>> For docker images, we may choose one to release. I don't really > >> > have a > >> > > >>>> preference. Maybe market share is a good indicator. I think > >> Ubuntu > >> > was > >> > > >>> #1 a > >> > > >>>> few years ago, but I am not sure what is the current case. > >> > > >>>> > >> > > >>>> So overall my vote would be, > >> > > >>>> docker image: ubuntu or current #1 market share wise if we can > >> find > >> > > the > >> > > >>>> information. > >> > > >>>> installer: MacOS + the same OS as the docker image. > >> > > >>>> > >> > > >>>> > >> > > >>>> On Mon, Feb 3, 2020 at 5:02 AM Josh Fischer < > j...@joshfischer.io > >> > > >> > > >> wrote: > >> > > >>>> > >> > > >>>>> Any thoughts on this email? > >> > > >>>>> > >> > > >>>>> Hi All, > >> > > >>>>> > >> > > >>>>> After several conversations with people across the Heron repo > >> we > >> > > >> keep > >> > > >>>>> hearing that a Heron convenience binary release would be > >> > appreciated. > >> > > >>>>> Based on some feedback from Dave we need to decide on what > type > >> of > >> > > >>>>> packaging is helpful to Heron users as the first step to > getting > >> > > >> people > >> > > >>>>> what they want/need. > >> > > >>>>> > >> > > >>>>> Right now we have, but not released in a while: > >> > > >>>>> > >> > > >>>>> Heron Docker Containers: > >> > > >>>>> - CentOS > >> > > >>>>> - Ubuntu > >> > > >>>>> - Debian > >> > > >>>>> Heron install scripts > >> > > >>>>> - CentOS > >> > > >>>>> - Darwin (MacOs) > >> > > >>>>> - Ubuntu > >> > > >>>>> > >> > > >>>>> Does anyone have a preference on which package and distro they > >> > would > >> > > >>> like > >> > > >>>>> us to start with? If possible, I would like us to scope down > to > >> > one > >> > > >>>>> supported docker image to use for Heron. Maintaining 3 > separate > >> > > >> images > >> > > >>>> is > >> > > >>>>> quite a task. > >> > > >>>>> > >> > > >>>>> On Tue, Jan 28, 2020 at 4:51 PM Josh Fischer < > >> j...@joshfischer.io> > >> > > >>>> wrote: > >> > > >>>>> > >> > > >>>>>> Hi All, > >> > > >>>>>> > >> > > >>>>>> After several conversations with people across the Heron > repo > >> we > >> > > >>> keep > >> > > >>>>>> hearing that a Heron convenience binary release would be > >> > > >> appreciated. > >> > > >>>>>> Based on some feedback from Dave we need to decide on what > >> type of > >> > > >>>>>> packaging is helpful to Heron users as the first step to > >> getting > >> > > >>> people > >> > > >>>>>> what they want/need. > >> > > >>>>>> > >> > > >>>>>> Right now we have, but not released in a while: > >> > > >>>>>> > >> > > >>>>>> Heron Docker Containers: > >> > > >>>>>> - CentOS > >> > > >>>>>> - Ubuntu > >> > > >>>>>> - Debian > >> > > >>>>>> Heron install scripts > >> > > >>>>>> - CentOS > >> > > >>>>>> - Darwin (MacOs) > >> > > >>>>>> - Ubuntu > >> > > >>>>>> > >> > > >>>>>> Does anyone have a preference on which package and distro > they > >> > > >> would > >> > > >>>> like > >> > > >>>>>> us to start with? If possible, I would like us to scope down > >> to > >> > > >> one > >> > > >>>>>> supported docker image to use for Heron. Maintaining 3 > >> separate > >> > > >>> images > >> > > >>>>> is > >> > > >>>>>> quite a task. > >> > > >>>>>> > >> > > >>>>>> - Josh > >> > > >>>>>> > >> > > >>>>> > >> > > >>>> > >> > > >>> > >> > > >> > >> > > > >> > > > >> > > >> > > >
