Re: Review Request 51397: HIVE-14536 Unit test code cleanup

2016-08-25 Thread Peter Vary
> On Aug. 26, 2016, 2:01 a.m., Siddharth Seth wrote: > > Not a lot here related to the patch itself in this comment. > > Looks like everyone has gotten interested in fixing Hive tests at about the > > same time - and there's a good reason for that :) > > I think it would be better to get changes

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

2016-08-25 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/ --- (Updated Aug. 26, 2016, 2:38 a.m.) Review request for hive, Ashutosh Chauhan, G

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

2016-08-25 Thread Peter Vary
> On Aug. 25, 2016, 10:46 p.m., Zoltan Haindrich wrote: > > This patch is huge...it was very time consuming doing its review - it would > > have been much better to split some of it into smaller changes Hi Zoltan, I know it is a big patch, and I appreciate your review very much, however I did

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

2016-08-25 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/#review146909 --- Not a lot here related to the patch itself in this comment. Looks

[jira] [Created] (HIVE-14652) incorrect results for not in on partition columns

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14652: --- Summary: incorrect results for not in on partition columns Key: HIVE-14652 URL: https://issues.apache.org/jira/browse/HIVE-14652 Project: Hive Issue Ty

Re: Review Request 51381: HIVE-14427: CompactionTxnHandler.markCleaned() can delete aborted txns

2016-08-25 Thread Barna Zsombor Klara
> On Aug. 25, 2016, 11:47 p.m., Gabor Szadovszky wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java, > > line 412 > > > > > > Not sure what would be the maximum number of ro

[jira] [Created] (HIVE-14651) Add a local cluster for Tez and LLAP

2016-08-25 Thread Siddharth Seth (JIRA)
Siddharth Seth created HIVE-14651: - Summary: Add a local cluster for Tez and LLAP Key: HIVE-14651 URL: https://issues.apache.org/jira/browse/HIVE-14651 Project: Hive Issue Type: Task

Re: Review Request 51381: HIVE-14427: CompactionTxnHandler.markCleaned() can delete aborted txns

2016-08-25 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51381/ --- (Updated Aug. 26, 2016, 12:12 a.m.) Review request for hive and Eugene Koifman.

Re: Review Request 51381: HIVE-14427: CompactionTxnHandler.markCleaned() can delete aborted txns

2016-08-25 Thread Gabor Szadovszky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51381/#review146886 --- Some minor findings/questions. LGTM, otherwise. metastore/src/ja

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

2016-08-25 Thread Peter Vary
> On Aug. 25, 2016, 10 p.m., Gabor Szadovszky wrote: > > itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestBeeLineDriver.java, > > line 39 > > > > > > Might worth to have the same explanation as you've had in

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

2016-08-25 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/ --- (Updated Aug. 25, 2016, 11:24 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

2016-08-25 Thread Peter Vary
> On Aug. 25, 2016, 4:55 p.m., Barna Zsombor Klara wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java, line > > 2276 > > > > > > Nit: Can we decide on whether to use System.out or System.

Re: Review Request 51395: HIVE-14626: Support Trash in Truncate Table

2016-08-25 Thread Gabor Szadovszky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51395/#review146881 --- LGTM. Thanks for the patch. - Gabor Szadovszky On Aug. 24, 2016

[jira] [Created] (HIVE-14650) Select fails when ORC file has more columns than table schema

2016-08-25 Thread Jeff Mink (JIRA)
Jeff Mink created HIVE-14650: Summary: Select fails when ORC file has more columns than table schema Key: HIVE-14650 URL: https://issues.apache.org/jira/browse/HIVE-14650 Project: Hive Issue Typ

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

2016-08-25 Thread Gabor Szadovszky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51435/#review146879 --- LGTM, thanks for the patch. - Gabor Szadovszky On Aug. 25, 2016

[jira] [Created] (HIVE-14649) handle ACID (or preclude ACID depending on the approach chosen)

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14649: --- Summary: handle ACID (or preclude ACID depending on the approach chosen) Key: HIVE-14649 URL: https://issues.apache.org/jira/browse/HIVE-14649 Project: Hive

[jira] [Created] (HIVE-14648) LLAP: Avoid private pages in the SSD cache

2016-08-25 Thread Gopal V (JIRA)
Gopal V created HIVE-14648: -- Summary: LLAP: Avoid private pages in the SSD cache Key: HIVE-14648 URL: https://issues.apache.org/jira/browse/HIVE-14648 Project: Hive Issue Type: Bug Compone

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

2016-08-25 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/#review146818 --- This patch is huge...it was very time consuming doing its review -

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

2016-08-25 Thread Gabor Szadovszky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/#review146857 --- 1 major & 1 minor comments. Otherwise, LGTM. Great work, thanks a

[GitHub] hive pull request #99: HIVE-14647: Typo fixes in Beeline help

2016-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/hive/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

Re: Review Request 50510: HIVE-14360 Starting BeeLine after using !save, there is an error logged: "Error setting configuration: conf"

2016-08-25 Thread Vihang Karajgaonkar
> On July 28, 2016, 4:37 a.m., Vihang Karajgaonkar wrote: > > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java, line 627 > > > > > > Adding @Ignore may not be the right solution here. This will skip > > sav

Re: Review Request 50510: HIVE-14360 Starting BeeLine after using !save, there is an error logged: "Error setting configuration: conf"

2016-08-25 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50510/#review146862 --- Ship it! LGTM. Thanks for the change. - Vihang Karajgaonkar

[jira] [Created] (HIVE-14647) Typo fixes in Beeline help

2016-08-25 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-14647: Summary: Typo fixes in Beeline help Key: HIVE-14647 URL: https://issues.apache.org/jira/browse/HIVE-14647 Project: Hive Issue Type: Bug

[GitHub] hive pull request #99: Typo fixes in Beeline help

2016-08-25 Thread mbalassi
GitHub user mbalassi opened a pull request: https://github.com/apache/hive/pull/99 Typo fixes in Beeline help Passing multiple arguments separated by semicolons requires to be within quotation marks. You can merge this pull request into a Git repository by running: $ git pull

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

2016-08-25 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51435/ --- (Updated Aug. 25, 2016, 8:36 p.m.) Review request for hive, Chaoyu Tang, Gabor

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

2016-08-25 Thread Peter Vary
> On Aug. 25, 2016, 6:42 p.m., Barna Zsombor Klara wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java, line 73 > > > > > > Isn't hiddenSet.clear() redundant here? We just created it on line 71.

[jira] [Created] (HIVE-14646) poison metastore APIs to make sure we can fail old clients for backward compat

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14646: --- Summary: poison metastore APIs to make sure we can fail old clients for backward compat Key: HIVE-14646 URL: https://issues.apache.org/jira/browse/HIVE-14646 Pr

[jira] [Created] (HIVE-14644) use metastore information on the read path appropriately

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14644: --- Summary: use metastore information on the read path appropriately Key: HIVE-14644 URL: https://issues.apache.org/jira/browse/HIVE-14644 Project: Hive I

[jira] [Created] (HIVE-14645) table conversion to and from MM

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14645: --- Summary: table conversion to and from MM Key: HIVE-14645 URL: https://issues.apache.org/jira/browse/HIVE-14645 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-14639) handle SKEWED BY

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14639: --- Summary: handle SKEWED BY Key: HIVE-14639 URL: https://issues.apache.org/jira/browse/HIVE-14639 Project: Hive Issue Type: Sub-task Reporter

[jira] [Created] (HIVE-14642) handle insert overwrite

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14642: --- Summary: handle insert overwrite Key: HIVE-14642 URL: https://issues.apache.org/jira/browse/HIVE-14642 Project: Hive Issue Type: Sub-task R

[jira] [Created] (HIVE-14643) handle ctas

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14643: --- Summary: handle ctas Key: HIVE-14643 URL: https://issues.apache.org/jira/browse/HIVE-14643 Project: Hive Issue Type: Sub-task Reporter: Ser

[jira] [Created] (HIVE-14640) handle hive.merge.*files

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14640: --- Summary: handle hive.merge.*files Key: HIVE-14640 URL: https://issues.apache.org/jira/browse/HIVE-14640 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-14641) handle writing to dynamic partitions

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14641: --- Summary: handle writing to dynamic partitions Key: HIVE-14641 URL: https://issues.apache.org/jira/browse/HIVE-14641 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-14636) pass information from FSOP/TezTask to MoveTask to take care of speculative execution and failed tasks

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14636: --- Summary: pass information from FSOP/TezTask to MoveTask to take care of speculative execution and failed tasks Key: HIVE-14636 URL: https://issues.apache.org/jira/browse/HIV

[jira] [Created] (HIVE-14638) handle Tez unions

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14638: --- Summary: handle Tez unions Key: HIVE-14638 URL: https://issues.apache.org/jira/browse/HIVE-14638 Project: Hive Issue Type: Sub-task Reporte

[jira] [Created] (HIVE-14637) edit or split MoveTask to commit files to metastore

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14637: --- Summary: edit or split MoveTask to commit files to metastore Key: HIVE-14637 URL: https://issues.apache.org/jira/browse/HIVE-14637 Project: Hive Issue

[jira] [Created] (HIVE-14635) establish a separate path for FSOP to write into final path

2016-08-25 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14635: --- Summary: establish a separate path for FSOP to write into final path Key: HIVE-14635 URL: https://issues.apache.org/jira/browse/HIVE-14635 Project: Hive

[jira] [Created] (HIVE-14634) TxnHandler.heartbeatTxnRange() can be done in 1 SQL statement

2016-08-25 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-14634: - Summary: TxnHandler.heartbeatTxnRange() can be done in 1 SQL statement Key: HIVE-14634 URL: https://issues.apache.org/jira/browse/HIVE-14634 Project: Hive

Re: Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

2016-08-25 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51435/#review146830 --- common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java (li

[jira] [Created] (HIVE-14633) #.of Files in a partition ! = #.Of buckets in a partitioned,bucketed table

2016-08-25 Thread Hanu (JIRA)
Hanu created HIVE-14633: --- Summary: #.of Files in a partition ! = #.Of buckets in a partitioned,bucketed table Key: HIVE-14633 URL: https://issues.apache.org/jira/browse/HIVE-14633 Project: Hive Issue

Review Request 51435: HIVE-14426 Extensive logging on info level in WebHCat

2016-08-25 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51435/ --- Review request for hive, Chaoyu Tang, Gabor Szadovszky, Sergio Pena, and Barna Z

[jira] [Created] (HIVE-14632) beeline outputformat needs better documentation

2016-08-25 Thread Michael Howard (JIRA)
Michael Howard created HIVE-14632: - Summary: beeline outputformat needs better documentation Key: HIVE-14632 URL: https://issues.apache.org/jira/browse/HIVE-14632 Project: Hive Issue Type: Im

Re: Review Request 51397: HIVE-14536 Unit test code cleanup

2016-08-25 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51397/#review146792 --- itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliC

Realm is required in beeline connection for users if display and logon name differs ,even its ensured with ldap authentciation

2016-08-25 Thread mathes waran
*Problem*: Realm is required in beeline connection for users if display and logon name differs ,even its ensured with ldap authentciation? While connecting with beeline,with configured ldap authentication some users connected without realm and some users connect with realm authentication.This is

[jira] [Created] (HIVE-14631) HiveServer2 regularly fails to connect to metastore

2016-08-25 Thread Alexandre Linte (JIRA)
Alexandre Linte created HIVE-14631: -- Summary: HiveServer2 regularly fails to connect to metastore Key: HIVE-14631 URL: https://issues.apache.org/jira/browse/HIVE-14631 Project: Hive Issue Ty