Re: Review Request 51695: HIVE-5867: JDBC driver and beeline should support executing an initial SQL script

2016-09-20 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51695/#review149793 --- jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java (line

Re: Review Request 48839: HIVE-14029: Update Spark version to 2.0.0

2016-09-20 Thread cheng xu
> On Sept. 21, 2016, 8:54 a.m., Szehon Ho wrote: > > This looks straight-forward and good to me (once 2.0.0 is the version in > > pom) Thanks Sezhon for your review. I have updated some versions required by Spark side. - cheng ---

Re: Review Request 48839: HIVE-14029: Update Spark version to 2.0.0

2016-09-20 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48839/ --- (Updated Sept. 21, 2016, 1:27 p.m.) Review request for hive, Rui Li, Sergio

Re: Review Request 48839: HIVE-14029: Update Spark version to 2.0.0

2016-09-20 Thread cheng xu
> On Sept. 21, 2016, 3:44 a.m., Sahil Takiar wrote: > > pom.xml, line 179 > > > > > > Can this be changed to `2.0.0` instead of `2.0.0-preview` > > Sahil Takiar wrote: > Looked at your updated patch, seems like

Re: Review Request 51695: HIVE-5867: JDBC driver and beeline should support executing an initial SQL script

2016-09-20 Thread Jianguo Tian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51695/ --- (Updated Sept. 21, 2016, 3:47 a.m.) Review request for hive and cheng xu.

Re: Review Request 51694: HIVE-14713 LDAP Authentication Provider should be covered with unit tests

2016-09-20 Thread Chaoyu Tang
> On Sept. 17, 2016, 1:36 a.m., Chaoyu Tang wrote: > > service/src/java/org/apache/hive/service/auth/ldap/Query.java, line 122 > > > > > > Will it improve the performance to set the search limit? I did not see > >

Re: Review Request 51694: HIVE-14713 LDAP Authentication Provider should be covered with unit tests

2016-09-20 Thread Chaoyu Tang
> On Sept. 17, 2016, 1:36 a.m., Chaoyu Tang wrote: > > service/src/java/org/apache/hive/service/auth/ldap/LdapUtils.java, line 105 > > > > > > This method might throw out runtime exception such as NPE, > >

[jira] [Created] (HIVE-14803) S3: Stats gathering for insert queries can be expensive for partitioned dataset

2016-09-20 Thread Rajesh Balamohan (JIRA)
Rajesh Balamohan created HIVE-14803: --- Summary: S3: Stats gathering for insert queries can be expensive for partitioned dataset Key: HIVE-14803 URL: https://issues.apache.org/jira/browse/HIVE-14803

Re: Review Request 48839: HIVE-14029: Update Spark version to 2.0.0

2016-09-20 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48839/#review149771 --- Ship it! This looks straight-forward and good to me (once

Re: Review Request 51694: HIVE-14713 LDAP Authentication Provider should be covered with unit tests

2016-09-20 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51694/#review149769 --- Ship it! This looks like a great refactoring to me. This class

[jira] [Created] (HIVE-14802) bogus HiveMetaStore.getDelegationToken calls in HS2 session opening

2016-09-20 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14802: --- Summary: bogus HiveMetaStore.getDelegationToken calls in HS2 session opening Key: HIVE-14802 URL: https://issues.apache.org/jira/browse/HIVE-14802 Project:

[jira] [Created] (HIVE-14801) improve TestPartitionNameWhitelistValidation stability

2016-09-20 Thread Thejas M Nair (JIRA)
Thejas M Nair created HIVE-14801: Summary: improve TestPartitionNameWhitelistValidation stability Key: HIVE-14801 URL: https://issues.apache.org/jira/browse/HIVE-14801 Project: Hive Issue

Re: Review Request 48839: HIVE-14029: Update Spark version to 2.0.0

2016-09-20 Thread Sahil Takiar
> On Sept. 20, 2016, 7:44 p.m., Sahil Takiar wrote: > > pom.xml, line 179 > > > > > > Can this be changed to `2.0.0` instead of `2.0.0-preview` Looked at your updated patch, seems like you already did this. -

Re: Review Request 48839: HIVE-14029: Update Spark version to 2.0.0

2016-09-20 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48839/#review149717 --- pom.xml (line 179)

[jira] [Created] (HIVE-14800) Handle off by 3 in ORC split generation based on split strategy used

2016-09-20 Thread Siddharth Seth (JIRA)
Siddharth Seth created HIVE-14800: - Summary: Handle off by 3 in ORC split generation based on split strategy used Key: HIVE-14800 URL: https://issues.apache.org/jira/browse/HIVE-14800 Project: Hive

Re: Review Request 51694: HIVE-14713 LDAP Authentication Provider should be covered with unit tests

2016-09-20 Thread Illya Yalovyy
> On Sept. 17, 2016, 1:36 a.m., Chaoyu Tang wrote: > > service/src/java/org/apache/hive/service/auth/ldap/GroupFilterFactory.java, > > line 37 > > > > > > Do we really need an extra factory layer and have a factory

Re: Review Request 50525: HIVE-14341: Altered skewed location is not respected for list bucketing

2016-09-20 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50525/#review149671 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java

[jira] [Created] (HIVE-14799) Query operation are not thread safe during its cancellation

2016-09-20 Thread Chaoyu Tang (JIRA)
Chaoyu Tang created HIVE-14799: -- Summary: Query operation are not thread safe during its cancellation Key: HIVE-14799 URL: https://issues.apache.org/jira/browse/HIVE-14799 Project: Hive Issue

[jira] [Created] (HIVE-14798) MSCK REPAIR TABLE throws null pointer exception

2016-09-20 Thread Anbu Cheeralan (JIRA)
Anbu Cheeralan created HIVE-14798: - Summary: MSCK REPAIR TABLE throws null pointer exception Key: HIVE-14798 URL: https://issues.apache.org/jira/browse/HIVE-14798 Project: Hive Issue Type:

Re: Review Request 52079: HIVE-14753: Track the number of open/closed/abandoned sessions in HS2

2016-09-20 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52079/#review149648 --- LGTM, Thanks for the patch - Peter Vary On Sept. 20, 2016,

Re: Review Request 52079: HIVE-14753: Track the number of open/closed/abandoned sessions in HS2

2016-09-20 Thread Gabor Szadovszky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52079/#review149643 --- Ship it! Thanks for the patch. LGTM. - Gabor Szadovszky On

Re: Review Request 50525: HIVE-14341: Altered skewed location is not respected for list bucketing

2016-09-20 Thread Yongzhi Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50525/#review149640 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java

Review Request 52079: HIVE-14753: Track the number of open/closed/abandoned sessions in HS2

2016-09-20 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52079/ --- Review request for hive, Gabor Szadovszky, Peter Vary, and Sergio Pena.

Re: Review Request 50525: HIVE-14341: Altered skewed location is not respected for list bucketing

2016-09-20 Thread Yongzhi Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50525/#review149635 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java

[jira] [Created] (HIVE-14797) reducer number estimating may lead to data skew

2016-09-20 Thread roncenzhao (JIRA)
roncenzhao created HIVE-14797: - Summary: reducer number estimating may lead to data skew Key: HIVE-14797 URL: https://issues.apache.org/jira/browse/HIVE-14797 Project: Hive Issue Type:

[jira] [Created] (HIVE-14796) MetastoreEventListener - OnGrant() and OnRevoke() Events required for capturing the event on grant and revoke operation on the table in hive.

2016-09-20 Thread Rahul Dhote (JIRA)
Rahul Dhote created HIVE-14796: -- Summary: MetastoreEventListener - OnGrant() and OnRevoke() Events required for capturing the event on grant and revoke operation on the table in hive. Key: HIVE-14796 URL: