[GitHub] hive pull request #140: HIVE-15746: Fix default delimiter2 value in str_to_m...

2017-01-27 Thread apivovarov
GitHub user apivovarov opened a pull request: https://github.com/apache/hive/pull/140 HIVE-15746: Fix default delimiter2 value in str_to_map UDF description https://issues.apache.org/jira/browse/HIVE-15746 You can merge this pull request into a Git repository by running: $ git

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

2017-01-27 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55994/#review163375 --- ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java (line 8

[jira] [Created] (HIVE-15747) change LlapServiceDriver to run entirely/mostly in Java

2017-01-27 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-15747: --- Summary: change LlapServiceDriver to run entirely/mostly in Java Key: HIVE-15747 URL: https://issues.apache.org/jira/browse/HIVE-15747 Project: Hive Is

[jira] [Created] (HIVE-15746) Fix default delimiter2 in str_to_map UDF or in method description

2017-01-27 Thread Alexander Pivovarov (JIRA)
Alexander Pivovarov created HIVE-15746: -- Summary: Fix default delimiter2 in str_to_map UDF or in method description Key: HIVE-15746 URL: https://issues.apache.org/jira/browse/HIVE-15746 Project:

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

2017-01-27 Thread Sergio Pena
> On Jan. 27, 2017, 3:37 p.m., Peter Vary wrote: > > Hi Sergio, > > > > Looking through the patch I did not find anything useful to enhance what > > you did :) > > > > I did run the yetus pre-commit stuff on it (author, checkstyle, javadoc, > > findbugs, whitespace, asflicense), and it came u

Re: Missing ASF license headers

2017-01-27 Thread Peter Vary
Thanks Owen, I will do that! Peter 2017. jan. 27. 19:02 ezt írta ("Owen O'Malley" ): > Just file a jira with the patch that adds the headers. > > .. Owen > > On Fri, Jan 27, 2017 at 8:08 AM, Peter Vary wrote: > > > Hi, > > > > I am working on enabling YETUS pre-commit test so it can help in the

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

2017-01-27 Thread Peter Vary
> On jan. 27, 2017, 3:37 du, Peter Vary wrote: > > Hi Sergio, > > > > Looking through the patch I did not find anything useful to enhance what > > you did :) > > > > I did run the yetus pre-commit stuff on it (author, checkstyle, javadoc, > > findbugs, whitespace, asflicense), and it came up

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

2017-01-27 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55994/ --- (Updated Jan. 27, 2017, 7:21 p.m.) Review request for hive, Mohit Sabharwal, Sa

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

2017-01-27 Thread Sergio Pena
> On Jan. 27, 2017, 3:37 p.m., Peter Vary wrote: > > Hi Sergio, > > > > Looking through the patch I did not find anything useful to enhance what > > you did :) > > > > I did run the yetus pre-commit stuff on it (author, checkstyle, javadoc, > > findbugs, whitespace, asflicense), and it came u

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

2017-01-27 Thread Sergio Pena
> On Jan. 27, 2017, 3:23 a.m., Sahil Takiar wrote: > > ql/src/test/org/apache/hadoop/hive/ql/exec/InputEstimatorTestClass.java, > > line 40 > > > > > > Is this necessary? It was the only way I thought on testing the

Re: Missing ASF license headers

2017-01-27 Thread Owen O'Malley
Just file a jira with the patch that adds the headers. .. Owen On Fri, Jan 27, 2017 at 8:08 AM, Peter Vary wrote: > Hi, > > I am working on enabling YETUS pre-commit test so it can help in the > reviews. > > I was running the ASF license check, and I have found the following files > are missing

Review Request 56025: HIVE-15723 Hive should report a warning about missing table/column statistics to user.

2017-01-27 Thread Remus Rusanu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56025/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git Descriptio

Re: Review Request 55932: HIVE-15387: NPE in HiveServer2 webUI Historical SQL Operations section

2017-01-27 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55932/#review163284 --- Ship it! LGTM. +1 - Chaoyu Tang On Jan. 25, 2017, 3:03 p.m.,

Re: Review Request 55498: HIVE-15538: Test HIVE-13884 with more complex query predicates

2017-01-27 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55498/#review163279 --- Thanks for the patch and it looks good. However, I have a couple o

Re: Review Request 54065: HIVE-15282: Different modification times are used when an index is built and when its staleness is checked

2017-01-27 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54065/#review163281 --- ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 968

Missing ASF license headers

2017-01-27 Thread Peter Vary
Hi, I am working on enabling YETUS pre-commit test so it can help in the reviews. I was running the ASF license check, and I have found the following files are missing the ASF header: common/src/java/org/apache/hadoop/hive/common/classification/RetrySemantics.java druid-handler/src/java/org/apac

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

2017-01-27 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55994/#review163277 --- Hi Sergio, Looking through the patch I did not find anything usef