Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

2017-05-12 Thread Lefty Leverenz
> On May 12, 2017, 3:01 a.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 3357-3361 (patched) > > > > > > Looks good, just some minor suggestions: > > > > -

Re: [Announce] New committer: Vineet Garg

2017-05-12 Thread Vineet Garg
Thanks ! > On May 11, 2017, at 10:07 PM, Rajesh Balamohan wrote: > > Congrats Vineet! > > ~Rajesh.B > > On Fri, May 12, 2017 at 10:04 AM, Lefty Leverenz > wrote: > >> Congratulations Vineet! >> >> -- Lefty >> >> >> On Wed, May 10, 2017 at 2:08 PM, Vineet Garg >> wrote: >> >>> Thanks all!

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

2017-05-12 Thread Vihang Karajgaonkar
> On May 12, 2017, 3:01 a.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 3351-3355 (original), 3351-3355 (patched) > > > > > > Please use newlines (\n) so the gener

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

2017-05-12 Thread Vihang Karajgaonkar
> On May 12, 2017, 2:18 p.m., Aihua Xu wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 3357-3361 (patched) > > > > > > Vihang and Sahil, > > > > Typically what would cause the

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

2017-05-12 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58936/ --- (Updated May 12, 2017, 9:35 p.m.) Review request for hive, Aihua Xu, Sergio Pen

[jira] [Created] (HIVE-16665) Race condition in Utilities.GetInputPathsCallable --> createDummyFileForEmptyPartition

2017-05-12 Thread Sahil Takiar (JIRA)
Sahil Takiar created HIVE-16665: --- Summary: Race condition in Utilities.GetInputPathsCallable --> createDummyFileForEmptyPartition Key: HIVE-16665 URL: https://issues.apache.org/jira/browse/HIVE-16665 Pr

[jira] [Created] (HIVE-16664) Add join related Hive blobstore tests

2017-05-12 Thread Rentao Wu (JIRA)
Rentao Wu created HIVE-16664: Summary: Add join related Hive blobstore tests Key: HIVE-16664 URL: https://issues.apache.org/jira/browse/HIVE-16664 Project: Hive Issue Type: Test Compone

[jira] [Created] (HIVE-16663) String Caching For Rows

2017-05-12 Thread BELUGA BEHR (JIRA)
BELUGA BEHR created HIVE-16663: -- Summary: String Caching For Rows Key: HIVE-16663 URL: https://issues.apache.org/jira/browse/HIVE-16663 Project: Hive Issue Type: Improvement Components

Re: Review Request 59205: HIVE-16579: CachedStore: improvements to partition col stats caching and cache column stats for unpartitioned table

2017-05-12 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59205/#review174841 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Line 90

[jira] [Created] (HIVE-16662) Fix remaining unit test failures when CachedStore is enabled

2017-05-12 Thread Daniel Dai (JIRA)
Daniel Dai created HIVE-16662: - Summary: Fix remaining unit test failures when CachedStore is enabled Key: HIVE-16662 URL: https://issues.apache.org/jira/browse/HIVE-16662 Project: Hive Issue Ty

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

2017-05-12 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58936/#review174792 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines 3

[jira] [Created] (HIVE-16661) Parquet storage does not handle 'or' statement properly

2017-05-12 Thread Tony Hill (JIRA)
Tony Hill created HIVE-16661: Summary: Parquet storage does not handle 'or' statement properly Key: HIVE-16661 URL: https://issues.apache.org/jira/browse/HIVE-16661 Project: Hive Issue Type: Bug

Re: Review Request 59137: HIVE-16602: Implement shared scans with Tez

2017-05-12 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59137/ --- (Updated May 12, 2017, 1:50 p.m.) Review request for hive, Ashutosh Chauhan and

Re: Review Request 59137: HIVE-16602: Implement shared scans with Tez

2017-05-12 Thread Jesús Camacho Rodríguez
> On May 11, 2017, 1:23 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java > > Lines 292-293 (original), 292-293 (patched) > > > > > > Does both conditions ne

Re: Review Request 59137: HIVE-16602: Implement shared scans with Tez

2017-05-12 Thread Jesús Camacho Rodríguez
> On May 11, 2017, 3:35 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedScanOptimizer.java > > Lines 460 (patched) > > > > > > I am not sure if this function is needed. When we

[jira] [Created] (HIVE-16660) Not able to add partition for views in hive when sentry is enabled

2017-05-12 Thread Yongzhi Chen (JIRA)
Yongzhi Chen created HIVE-16660: --- Summary: Not able to add partition for views in hive when sentry is enabled Key: HIVE-16660 URL: https://issues.apache.org/jira/browse/HIVE-16660 Project: Hive

Re: Review Request 59070: HIVE-16555 : Add a new thrift API call for get_metastore_db_uuid

2017-05-12 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59070/#review174777 --- The patch looks good to me. Since this one is bigger I have run YE