Re: Review Request 61009: Extend object store to store bit vectors

2017-07-24 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61009/ --- (Updated July 25, 2017, 1:03 a.m.) Review request for hive and Ashutosh

Re: [VOTE] Shall we release Hive 2.2.0 rc1?

2017-07-24 Thread Ashutosh Chauhan
+1 built from sources. Ran few unit tests and queries. Looks good. Thanks, Ashutosh On Mon, Jul 24, 2017 at 3:02 PM, Alan Gates wrote: > +1, checked the signatures, did a build with a clean repo, ran RAT. > > Alan. > > On Fri, Jul 21, 2017 at 5:20 PM, Owen O'Malley

Re: Review Request 61009: Extend object store to store bit vectors

2017-07-24 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61009/#review181299 --- metastore/scripts/upgrade/mssql/029-HIVE-16997.mssql.sql Line 1

[jira] [Created] (HIVE-17161) BeeLine up arrow key should show the last sql instead of last line

2017-07-24 Thread Vihang Karajgaonkar (JIRA)
Vihang Karajgaonkar created HIVE-17161: -- Summary: BeeLine up arrow key should show the last sql instead of last line Key: HIVE-17161 URL: https://issues.apache.org/jira/browse/HIVE-17161

Apache ptest broken?

2017-07-24 Thread Deepak Jaiswal
Looks like ptest for hive is broken. https://builds.apache.org/view/H-L/view/Hive/job/PreCommit-HIVE-Build/# Regards, Deepak

Re: Review Request 61009: Extend object store to store bit vectors

2017-07-24 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61009/ --- (Updated July 24, 2017, 11:32 p.m.) Review request for hive and Ashutosh

Re: Review Request 61009: Extend object store to store bit vectors

2017-07-24 Thread pengcheng xiong
> On July 21, 2017, 10:45 p.m., Ashutosh Chauhan wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 1507-1508 (original) > > > > > > Seems like we are going to loose

Re: [DISCUSS] Separating out the metastore as its own TLP

2017-07-24 Thread Gopal Vijayaraghavan
Hi, Changing the name isn't really optional or "being google-able" [2]. The naming is a crucial part of trademark protection [1], which is the only protection ASF has against hostile Embrace & Extends. Fragmented forks with the same name is particularly bad, especially if the feature in

Re: [DISCUSS] Separating out the metastore as its own TLP

2017-07-24 Thread Carl Steinbach
+1 to Vihang's suggestion. Changing the name will only cause confusion. On Mon, Jul 24, 2017 at 2:28 PM, Johndee Cloudera wrote: > +1 Vihang, I do not really like Catalog as it could create confusion with > the Catalog daemon from impala. > > On Mon, Jul 24, 2017 at 5:20

Re: [VOTE] Shall we release Hive 2.2.0 rc1?

2017-07-24 Thread Alan Gates
+1, checked the signatures, did a build with a clean repo, ran RAT. Alan. On Fri, Jul 21, 2017 at 5:20 PM, Owen O'Malley wrote: > Ok, I rolled a new RC with the Apache header problem fixed. > > Artifacts: https://home.apache.org/~omalley/hive-2.2.0/ > Tag:

Re: Review Request 61087: HIVE-16965 SMB join may produce incorrect results

2017-07-24 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61087/ --- (Updated July 24, 2017, 9:35 p.m.) Review request for hive, Gopal V, Jason

Re: [DISCUSS] Separating out the metastore as its own TLP

2017-07-24 Thread Johndee Cloudera
+1 Vihang, I do not really like Catalog as it could create confusion with the Catalog daemon from impala. On Mon, Jul 24, 2017 at 5:20 PM, Vihang Karajgaonkar wrote: > Before we see a flood of name suggestions :) Why not just keep it > Metastore? Its already well-known in

Re: Review Request 61041: HIVE-17150: CREATE INDEX execute HMS out-of-transaction listener calls inside a transaction

2017-07-24 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61041/#review181268 --- Ship it! Ship It! - Vihang Karajgaonkar On July 21, 2017,

Re: [DISCUSS] Separating out the metastore as its own TLP

2017-07-24 Thread Vihang Karajgaonkar
Before we see a flood of name suggestions :) Why not just keep it Metastore? Its already well-known in the community and easy to relate to. On Mon, Jul 24, 2017 at 2:13 PM, Alan Gates wrote: > In the same vein Carter and Gunther suggested Omegastore. Pick your > alphabet

Re: [DISCUSS] Separating out the metastore as its own TLP

2017-07-24 Thread Alan Gates
In the same vein Carter and Gunther suggested Omegastore. Pick your alphabet and whether it’s a catalog or a store I guess. Alan. On Mon, Jul 24, 2017 at 1:35 PM, Sergey Shelukhin wrote: > I’d like to suggest ZCatalog. > > On 17/7/11, 15:41, "Lefty Leverenz"

[jira] [Created] (HIVE-17160) Adding kerberos Authorization to the Druid hive integration

2017-07-24 Thread slim bouguerra (JIRA)
slim bouguerra created HIVE-17160: - Summary: Adding kerberos Authorization to the Druid hive integration Key: HIVE-17160 URL: https://issues.apache.org/jira/browse/HIVE-17160 Project: Hive

Re: [DISCUSS] Separating out the metastore as its own TLP

2017-07-24 Thread Sergey Shelukhin
I’d like to suggest ZCatalog. On 17/7/11, 15:41, "Lefty Leverenz" wrote: >>> I'd like to suggest Riven. (Owen O'Malley) > >> How about "Flora"? (Andrew Sherman) > >Nice idea and thanks for introducing me to that book, Andrew. > >Along the same lines, how about

[jira] [Created] (HIVE-17159) Make metastore a separately releasable module

2017-07-24 Thread Alan Gates (JIRA)
Alan Gates created HIVE-17159: - Summary: Make metastore a separately releasable module Key: HIVE-17159 URL: https://issues.apache.org/jira/browse/HIVE-17159 Project: Hive Issue Type: New Feature

Re: Review Request 61087: HIVE-16965 SMB join may produce incorrect results

2017-07-24 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61087/#review181246 ---

Review Request 61087: HIVE-16965 SMB join may produce incorrect results

2017-07-24 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61087/ --- Review request for hive, Gopal V, Jason Dere, and Sergey Shelukhin. Bugs:

Re: Review Request 61009: Extend object store to store bit vectors

2017-07-24 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61009/#review181239 --- common/src/java/org/apache/hadoop/hive/common/ndv/FMSketch.java

Re: Review Request 61009: Extend object store to store bit vectors

2017-07-24 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61009/ --- (Updated July 24, 2017, 6:08 p.m.) Review request for hive and Ashutosh

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-24 Thread Andrew Sherman
> On July 24, 2017, 9:09 a.m., Peter Vary wrote: > > itests/hive-unit/src/test/java/org/apache/hive/service/cli/operation/TestOperationLoggingLayout.java > > Line 123 (original), 124 (patched) > > > > > > I might

[jira] [Created] (HIVE-17158) BeeLine Query Log and Query Result print order is not defined

2017-07-24 Thread Peter Vary (JIRA)
Peter Vary created HIVE-17158: - Summary: BeeLine Query Log and Query Result print order is not defined Key: HIVE-17158 URL: https://issues.apache.org/jira/browse/HIVE-17158 Project: Hive Issue

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-24 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61010/#review181196 --- Just 2 comments and they are not that important. Feel free to