Re: Review Request 71708: HIVE-22435

2019-11-19 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71708/ --- (Updated Nov. 19, 2019, 8:39 a.m.) Review request for hive, Gopal V, Jesús Cama

[jira] [Created] (HIVE-22511) Fix case of Month token in datetime to string conversion

2019-11-19 Thread Gabor Kaszab (Jira)
Gabor Kaszab created HIVE-22511: --- Summary: Fix case of Month token in datetime to string conversion Key: HIVE-22511 URL: https://issues.apache.org/jira/browse/HIVE-22511 Project: Hive Issue Typ

[jira] [Created] (HIVE-22512) Use direct SQL to fetch column privileges in refreshPrivileges

2019-11-19 Thread Ashutosh Bapat (Jira)
Ashutosh Bapat created HIVE-22512: - Summary: Use direct SQL to fetch column privileges in refreshPrivileges Key: HIVE-22512 URL: https://issues.apache.org/jira/browse/HIVE-22512 Project: Hive

Re: ORC: duplicate record - rowid meaning ?

2019-11-19 Thread David Morin
here after more details about ORC content and the fact we have duplicate rows: /delta_0011365_0011365_/bucket_3 {"operation":0,"originalTransaction":11365,"bucket":3,"rowId":0,"currentTransaction":11365,"row":{"TS":1574156027915254212,"cle":5218,...}} {"operation":0,"originalTransaction":

[jira] [Created] (HIVE-22513) Constant propagation of casted column in filter ops can cause incorrect results

2019-11-19 Thread Jira
Ádám Szita created HIVE-22513: - Summary: Constant propagation of casted column in filter ops can cause incorrect results Key: HIVE-22513 URL: https://issues.apache.org/jira/browse/HIVE-22513 Project: Hive

[jira] [Created] (HIVE-22514) HiveProtoLoggingHook might leak memory

2019-11-19 Thread Attila Magyar (Jira)
Attila Magyar created HIVE-22514: Summary: HiveProtoLoggingHook might leak memory Key: HIVE-22514 URL: https://issues.apache.org/jira/browse/HIVE-22514 Project: Hive Issue Type: Bug

Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71784/ --- Review request for hive, Laszlo Bodor, Harish Jaiprakash, Mustafa Iman, and Pano

Re: Review Request 71708: HIVE-22435

2019-11-19 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71708/ --- (Updated Nov. 19, 2019, 4:25 p.m.) Review request for hive, Gopal V, Jesús Cama

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Slim Bouguerra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71784/#review218679 --- ql/src/java/org/apache/hadoop/hive/ql/hooks/HiveProtoLoggingHook.

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Slim Bouguerra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71784/#review218680 --- the description is kind of confusing, is this a leak or we have sp

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Attila Magyar
> On Nov. 19, 2019, 6:53 p.m., Slim Bouguerra wrote: > > ql/src/java/org/apache/hadoop/hive/ql/hooks/HiveProtoLoggingHook.java > > Line 217 (original), 219 (patched) > > > > > > how this can solve the issue ? > >

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Attila Magyar
> On Nov. 19, 2019, 6:58 p.m., Slim Bouguerra wrote: > > the description is kind of confusing, is this a leak or we have spike of > > overload ? > > Leak means we are not cleaning the resources thus that is why we have an > > OOM. > > What you are describing seems to be a system overload that c

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Slim Bouguerra
> On Nov. 19, 2019, 6:53 p.m., Slim Bouguerra wrote: > > ql/src/java/org/apache/hadoop/hive/ql/hooks/HiveProtoLoggingHook.java > > Lines 274 (patched) > > > > > > looking at the java code i see that it is using a bou

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Attila Magyar
> On Nov. 19, 2019, 6:53 p.m., Slim Bouguerra wrote: > > ql/src/java/org/apache/hadoop/hive/ql/hooks/HiveProtoLoggingHook.java > > Lines 274 (patched) > > > > > > looking at the java code i see that it is using a bou

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Slim Bouguerra
> On Nov. 19, 2019, 6:53 p.m., Slim Bouguerra wrote: > > ql/src/java/org/apache/hadoop/hive/ql/hooks/HiveProtoLoggingHook.java > > Lines 279 (patched) > > > > > > i am still not sure how this is going to work? > >

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Panos Garefalakis via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71784/#review218694 --- ql/src/java/org/apache/hadoop/hive/ql/hooks/HiveProtoLoggingHook.

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Panos Garefalakis via Review Board
> On Nov. 19, 2019, 10:24 p.m., Panos Garefalakis wrote: > > ql/src/java/org/apache/hadoop/hive/ql/hooks/HiveProtoLoggingHook.java > > Lines 192 (patched) > > > > > > The solution makes sense to me, however maybe we

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Slim Bouguerra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71784/#review218697 --- I recommend using a bounded queue instead of checking the size and

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Attila Magyar
> On Nov. 19, 2019, 10:38 p.m., Slim Bouguerra wrote: > > I recommend using a bounded queue instead of checking the size and soing > > the if else everytime > > something like this might work > > ```java > > BlockingQueue linkedBlockingDeque = new > > LinkedBlockingDeque( > > 1); > >

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Attila Magyar
> On Nov. 19, 2019, 10:24 p.m., Panos Garefalakis wrote: > > ql/src/java/org/apache/hadoop/hive/ql/hooks/HiveProtoLoggingHook.java > > Lines 192 (patched) > > > > > > The solution makes sense to me, however maybe we

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Slim Bouguerra
> On Nov. 19, 2019, 10:38 p.m., Slim Bouguerra wrote: > > I recommend using a bounded queue instead of checking the size and soing > > the if else everytime > > something like this might work > > ```java > > BlockingQueue linkedBlockingDeque = new > > LinkedBlockingDeque( > > 1); > >

[jira] [Created] (HIVE-22515) Support cast to decimal64 in Vectorization

2019-11-19 Thread Ramesh Kumar Thangarajan (Jira)
Ramesh Kumar Thangarajan created HIVE-22515: --- Summary: Support cast to decimal64 in Vectorization Key: HIVE-22515 URL: https://issues.apache.org/jira/browse/HIVE-22515 Project: Hive

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Harish Jaiprakash
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71784/#review218709 --- Thanks for the change. This does solve the memory problem and it l

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Harish Jaiprakash
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71784/#review218710 --- ql/src/test/org/apache/hadoop/hive/ql/hooks/TestHiveProtoLoggingH