Hi All!

What do you think about forcing coding style in Hive precommit?

I remember, back in the old days, precommit printed some warnings in case
some coding style (formatting, indentation, naming convention, etc.)
problems were found in the patch, now it's simply not used, I guess since
we're using GitHub PRs.

For example: I remember I simply approved a PR a few months ago which LGTM,
and later just realized it's full of 4-spaces indentation, which is wrong
if we assume that code should be formatted according to the style
definition here:
https://github.com/apache/hive/blob/master/dev-support/eclipse-styles.xml

I have just attached an example of Tez PR to open minds and start a
conversation.

Regards,
Laszlo Bodor

Reply via email to