Re: Review Request 70256: HIVE-21480: Fixed flaky and broken test TestHiveMetaStore.testJDOPersistenceManagerCleanup

with the tests (vihang, pvary or someone) to also do a quick review. thanks. - Karthik Manamcheri On March 20, 2019, 5:07 p.m., Morio Ramdenbourg wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Error posting to reviewboard

: could not get object info (HTTP 400, API Error 224) Is this new? I can't use the review board UI either. Is someone else running into this problem with review board? -- *Karthik Manamcheri*

Re: Review Request 69914: HIVE-21227: HIVE-20776 causes view access regression

/hadoop/hive/metastore/HiveMetaStoreClient.java Line 2509 (original), 2512 (patched) <https://reviews.apache.org/r/69914/#comment298460> We should add unit tests to make sure that this doesn't happen again. Can you add a test which would fail if this fix wasn't there? - Karthik Mana

[jira] [Created] (HIVE-21169) Add StatementExecuteTime to bone cp metrics

Karthik Manamcheri created HIVE-21169: - Summary: Add StatementExecuteTime to bone cp metrics Key: HIVE-21169 URL: https://issues.apache.org/jira/browse/HIVE-21169 Project: Hive Issue

Re: Review Request 69664: HIVE-21077 : Database and Catalogs should have creation time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69664/#review212336 --- Ship it! Ship It! - Karthik Manamcheri On Jan. 15, 2019

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

/hadoop/hive/metastore/TestObjectStore.java Line 1082 (original) <https://reviews.apache.org/r/69834/#comment298096> Add a test to make sure that we don't throw an exception if the truststore path and password is empty. - Karthik Manamcheri On Jan. 25, 2019, 1:38 a.m., Morio Ramde

Re: Review Request 69834: HIVE-21083: Removed the truststore location property requirement and removed the warnings on the truststore password property

e do a LOG.info here stating that the truststore path has not been set and we will default to the Java truststore file? Same for the truststore password. - Karthik Manamcheri On Jan. 24, 2019, 11:16 p

Re: Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

the connection pool info) and also a timer for total api calls. Thanks, Karthik Manamcheri

Re: Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69672/#review211805 ----------- On Jan. 5, 2019, 12:41 a.m., Karthik Manamcheri wrote: > >

Re: Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

ics if metrics is disabled. - Karthik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69672/#review211805 --- On Jan. 5, 201

Re: Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

skip adding metrics if metrics is disabled. - Karthik Manamcheri On Jan. 5, 2019, 12:41 a.m., Karthik Manamcheri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

New logic is that it looks at the connectionPoolingType property, checks if there is a DataSourceProvider avaialble for the set property and creates one. If not, we fallback to the default JDOHelper.getPersistenceManagerFactory logic. Please correct me if I am wrong in my unders

Review Request 69672: HIVE-21045: Add total API timing stats and connection pool stats to metrics

. [BoneCP json metrics sample](https://gist.github.com/kmanamcheri/b005f68263a1a1be06b25156a159d975) In both the reports note that there are pool gauges (for tracking the connection pool info) and also a timer for total api calls. Thanks, Karthik Manamcheri

Re: Review Request 69664: HIVE-21077 : Database should have creation time

> On Jan. 4, 2019, 5:33 p.m., Karthik Manamcheri wrote: > > > > Karthik Manamcheri wrote: > 1. While we are at it, can we make sure that the "create time" exists for > everything else (if required)? Such as catalog, partitions.. > 2. Out of curiosi

Re: Review Request 69664: HIVE-21077 : Database should have creation time

> On Jan. 4, 2019, 5:33 p.m., Karthik Manamcheri wrote: > > 1. While we are at it, can we make sure that the "create time" exists for everything else (if required)? Such as catalog, partitions.. 2. Out of curiosity.. are there any tests to ensure that the upgrade path wor

Re: Review Request 69664: HIVE-21077 : Database should have creation time

(patched) <https://reviews.apache.org/r/69664/#comment297133> Why not just store it in milliseconds? - Karthik Manamcheri On Jan. 3, 2019, 11:44 p.m., Vihang Karajgaonkar wrote: > > --- > This is an automatically generated e

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

> On Jan. 3, 2019, 1:42 a.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java > > Lines 374 (patched) > > <https://reviews.apache.org/r/69642/diff/4/?file=21

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

think my current approach is more readable and maintainable. - Karthik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69642/#review211643 ---------

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

issue a getPartitionsByNames with an empty database, we threw an exception. After this change, we will return an empty list of partitions instead. This behavior is similar to what happens if you issue a getTablesByNames call (an empty list of tables are returned) - Karthik Manamcheri On Jan. 3, 2019, 1:

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

backup performance. Thanks, Karthik Manamcheri

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

-CREATION Diff: https://reviews.apache.org/r/69642/diff/3/ Changes: https://reviews.apache.org/r/69642/diff/2-3/ Testing --- Unit tests. Manual performance test with Cloudera BDR to notice improved backup performance. Thanks, Karthik Manamcheri

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

catch the RuntimeException, and rethrow the NoSuchObjectException (as it was doing before this change). - Karthik Manamcheri On Jan. 2, 2019, 8:15 p.m., Karthik Manamcheri wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

Diff: https://reviews.apache.org/r/69642/diff/2/ Testing --- Unit tests. Manual performance test with Cloudera BDR to notice improved backup performance. Thanks, Karthik Manamcheri

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 20, 2018, 2:46 p.m., Sergio Pena wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 220-221 (patched) > > > > > > These two

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

etastore/HiveMetaStore.java Lines 5235 (patched) <https://reviews.apache.org/r/69585/#comment296548> Can we make a helper fuction called "filterTablesIfEnabled"? - Karthik Manamcheri On Dec. 19, 2018, 6:57 a.m., Na Li wrote: > > --

[jira] [Created] (HIVE-21045) Add connection pool info and rolling performance info to the metrics system

Karthik Manamcheri created HIVE-21045: - Summary: Add connection pool info and rolling performance info to the metrics system Key: HIVE-21045 URL: https://issues.apache.org/jira/browse/HIVE-21045

[jira] [Created] (HIVE-21044) Add SLF4J reporter to the metrics system

Karthik Manamcheri created HIVE-21044: - Summary: Add SLF4J reporter to the metrics system Key: HIVE-21044 URL: https://issues.apache.org/jira/browse/HIVE-21044 Project: Hive Issue Type

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

> On Dec. 14, 2018, 2:58 a.m., Karthik Manamcheri wrote: > > Ship It! LGTM! Make sure you get someone else to review it as well. Thanks. - Karthik --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/#review211318 --- Ship it! Ship It! - Karthik Manamcheri On Dec. 14, 2018, 1

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

ched) <https://reviews.apache.org/r/69534/#comment296197> State that this is deprecated here and maybe increase the LOG to warn and note that this might be changed in next version of hive. - Karthik Manamcheri On Dec. 10, 2018, 8:51 p.m., Morio

[jira] [Created] (HIVE-21028) get_table_meta should use a fetch plan

Karthik Manamcheri created HIVE-21028: - Summary: get_table_meta should use a fetch plan Key: HIVE-21028 URL: https://issues.apache.org/jira/browse/HIVE-21028 Project: Hive Issue Type

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

pache.org/r/69534/#comment296052> I prefer using exceptions which tell the user what to do in addition to what is wrong. In this case, rephrase as, "SSL has been enabled but trust store path is empty. Set the xxx property to enable SSL. Disabling SSL and continuing" - Karthi

[jira] [Created] (HIVE-20986) Add TransactionalValidationListener to HMS preListeners only when ACID support is enabled

Karthik Manamcheri created HIVE-20986: - Summary: Add TransactionalValidationListener to HMS preListeners only when ACID support is enabled Key: HIVE-20986 URL: https://issues.apache.org/jira/browse/HIVE-20986

[jira] [Created] (HIVE-20977) Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

Karthik Manamcheri created HIVE-20977: - Summary: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance Key: HIVE-20977 URL: https://issues.apache.org/jira/browse/HIVE-20977

[jira] [Created] (HIVE-20776) Move HMS filterHooks from client-side to server-side

Karthik Manamcheri created HIVE-20776: - Summary: Move HMS filterHooks from client-side to server-side Key: HIVE-20776 URL: https://issues.apache.org/jira/browse/HIVE-20776 Project: Hive

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

> On Oct. 18, 2018, 2:33 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 244 (original), 341 (patched) > > <https://reviews.apache.org/r/69054/diff/2/?file=20

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

che.org/r/69054/#comment294298> Is this testing the new read/write lock behavior? As in, would this test have failed if you had the previous behavior of a global lock? - Karthik Manamcheri On Oct. 16, 2018, 10:47 p.m., Vihang

Question about HMS filter hooks

rstand if there were any concerning reasons why we shouldn't do so. Thanks, Karthik -- *Karthik Manamcheri* Software Engineer

Re: Review Request 68827: HIVE-20545 : Exclude large-sized parameters from serialization of Table and Partition thrift objects in HMS notifications

SONMessageFactory.java Lines 323 (patched) <https://reviews.apache.org/r/68827/#comment293625> Is there a reason why this filter is applied only to Table or Partition object? - Karthik Manamcheri On Oct. 2, 2018, 5:19 a.m., Bharathkri

[jira] [Created] (HIVE-20634) DirectSQL does not retry in ORM mode while getting partitions by filter

Karthik Manamcheri created HIVE-20634: - Summary: DirectSQL does not retry in ORM mode while getting partitions by filter Key: HIVE-20634 URL: https://issues.apache.org/jira/browse/HIVE-20634

Review Request 68590: HIVE-20493: Unit test getGroupNames for SessionStateUserAuthenticator

=TestSessionUserName test' successfully. Thanks, Karthik Manamcheri

[jira] [Created] (HIVE-20493) Unit test getGroupNames for SessionStateUserAuthenticator

Karthik Manamcheri created HIVE-20493: - Summary: Unit test getGroupNames for SessionStateUserAuthenticator Key: HIVE-20493 URL: https://issues.apache.org/jira/browse/HIVE-20493 Project: Hive

Re: Review Request 68571: HIVE-20372: WRTIE_SET typo in TxnHandler

/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 2df61b41ea Diff: https://reviews.apache.org/r/68571/diff/2/ Changes: https://reviews.apache.org/r/68571/diff/1-2/ Testing --- Thanks, Karthik Manamcheri

Review Request 68571: HIVE-20372: WRTIE_SET typo in TxnHandler

://reviews.apache.org/r/68571/diff/1/ Testing --- Thanks, Karthik Manamcheri