[jira] [Commented] (HIVE-2572) HIVE-2246 upgrade script changed the COLUMNS_V2.COMMENT length

2011-11-16 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151665#comment-13151665 ] Ning Zhang commented on HIVE-2572: -- backported to 0.8.0 > HIVE-2246 upgra

[jira] [Commented] (HIVE-2568) HIVE-2246 upgrade script needs to drop foreign key in COLUMNS_OLD

2011-11-16 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151666#comment-13151666 ] Ning Zhang commented on HIVE-2568: -- backported to 0.8.0 > HIVE-2246 upgra

[jira] [Commented] (HIVE-2567) Some CTAS queries with * and group by don't work.

2011-11-13 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149443#comment-13149443 ] Ning Zhang commented on HIVE-2567: -- Robert, this patch doesn't apply cleanly. Can you svn

[jira] [Commented] (HIVE-2472) Metastore statistics are not being updated for CTAS queries.

2011-11-10 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148128#comment-13148128 ] Ning Zhang commented on HIVE-2472: -- +1. > Metastore statistics are not be

[jira] [Commented] (HIVE-2553) Use hashing instead of list traversal for IN operator for primitive types

2011-11-10 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147844#comment-13147844 ] Ning Zhang commented on HIVE-2553: -- Robert, input49.q failed. Can you take a look?

[jira] [Commented] (HIVE-2562) HIVE-2247 Changed the Thrift API causing compatibility issues.

2011-11-09 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147527#comment-13147527 ] Ning Zhang commented on HIVE-2562: -- +1. Will commit if tests pass. > HIV

[jira] [Commented] (HIVE-2553) Use hashing instead of list traversal for IN operator for primitive types

2011-11-09 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147521#comment-13147521 ] Ning Zhang commented on HIVE-2553: -- +1. Will commit if tests pass. > Use

[jira] [Commented] (HIVE-2556) upgrade script 008-HIVE-2246.mysql.sql contains syntax errors

2011-11-07 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145972#comment-13145972 ] Ning Zhang commented on HIVE-2556: -- Review request: https://reviews.facebook.net/D309

[jira] [Commented] (HIVE-2545) Make metastore log4j configuration file configurable again.

2011-11-07 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145674#comment-13145674 ] Ning Zhang commented on HIVE-2545: -- +1. Will commit if tests pass. > Mak

[jira] [Commented] (HIVE-2366) Metastore upgrade scripts for HIVE-2246 do not migrate indexes nor rename the old COLUMNS table

2011-11-04 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144143#comment-13144143 ] Ning Zhang commented on HIVE-2366: -- Backported to branch 0.8 as well. >

[jira] [Commented] (HIVE-2366) Metastore upgrade scripts for HIVE-2246 do not migrate indexes nor rename the old COLUMNS table

2011-11-04 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144131#comment-13144131 ] Ning Zhang commented on HIVE-2366: -- +1. Will commit if tests pass. > Met

[jira] [Commented] (HIVE-2366) Metastore upgrade scripts for HIVE-2246 do not migrate indexes nor rename the old COLUMNS table

2011-11-01 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141885#comment-13141885 ] Ning Zhang commented on HIVE-2366: -- LGTM. Paul, can you double check? > M

[jira] [Commented] (HIVE-2510) Hive throws Null Pointer Exception upon CREATE TABLE . .... if the given doesn't exist

2011-11-01 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141354#comment-13141354 ] Ning Zhang commented on HIVE-2510: -- +1. Will commit if tests pass. > Hiv

[jira] [Commented] (HIVE-2525) Introduce proper error messages, when explain fails on commands that otherwise could be succesful (commands that are not analyzed by Semantic Analyzer)

2011-11-01 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141246#comment-13141246 ] Ning Zhang commented on HIVE-2525: -- I agree with Namit. The right approach is to throw a b

[jira] [Commented] (HIVE-2500) Allow Hive to be debugged remotely

2011-10-30 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139675#comment-13139675 ] Ning Zhang commented on HIVE-2500: -- +1. Will commit if tests pass. > All

[jira] [Commented] (HIVE-2522) HIVE-2446 bug (next one) - If constructor of ClientStatsPublisher throws runtime exception it will be propagated to HadoopJobExecHelper's progress method and beyond, whe

2011-10-24 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134528#comment-13134528 ] Ning Zhang commented on HIVE-2522: -- +1. Will commit if tests pass. > HIV

[jira] [Commented] (HIVE-2512) After HIVE-2145, Hive disallow any use of function in cluster-by clause

2011-10-24 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134290#comment-13134290 ] Ning Zhang commented on HIVE-2512: -- +1. Thanks for the quick response Chinna.

[jira] [Commented] (HIVE-2512) After HIVE-2145, Hive disallow any use of function in cluster-by clause

2011-10-21 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133035#comment-13133035 ] Ning Zhang commented on HIVE-2512: -- Chinna, the Hive wiki may only say it requires column

[jira] [Commented] (HIVE-2512) After HIVE-2145, Hive disallow any use of function in cluster-by clause

2011-10-21 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132831#comment-13132831 ] Ning Zhang commented on HIVE-2512: -- Chinna, I think the point for this JIRA is to allow fu

[jira] [Commented] (HIVE-2368) Determining whether a Column Descriptor is unused may take too long

2011-10-20 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132188#comment-13132188 ] Ning Zhang commented on HIVE-2368: -- @Paul Yang, this looks good to me. Can you also review

[jira] [Commented] (HIVE-2487) Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} l

2011-10-19 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130873#comment-13130873 ] Ning Zhang commented on HIVE-2487: -- Yongqiang, it seems you have committed this patch? Can

[jira] [Commented] (HIVE-2512) After HIVE-2145, Hive disallow any use of function in cluster-by clause

2011-10-19 Thread Ning Zhang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130788#comment-13130788 ] Ning Zhang commented on HIVE-2512: -- Cool. Thanks Chinna! Just a suggestions, I think rever