[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate quality hashCode()

2012-06-25 Thread Gang Tim Liu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400844#comment-13400844 ] Gang Tim Liu commented on HIVE-3165: @Carl, thank you:) > Hive thrift

[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate quality hashCode()

2012-06-25 Thread Gang Tim Liu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400820#comment-13400820 ] Gang Tim Liu commented on HIVE-3165: @Carl, good Monday. How tests go? what I can do fo

[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate quality hashCode()

2012-06-21 Thread Gang Tim Liu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398959#comment-13398959 ] Gang Tim Liu commented on HIVE-3165: @Carl, thanks @Namit, thanks > H

[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate quality hashCode()

2012-06-21 Thread Carl Steinbach (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398923#comment-13398923 ] Carl Steinbach commented on HIVE-3165: -- @Tim: Changes look good. +1. Will commit if te

[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate quality hashCode()

2012-06-21 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398907#comment-13398907 ] Namit Jain commented on HIVE-3165: -- @Carl, I am assuming you will take care of committing

[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate quality hashCode()

2012-06-21 Thread Gang Tim Liu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398579#comment-13398579 ] Gang Tim Liu commented on HIVE-3165: Test passed. another batch is submitted to https:/

[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate quality hashCode()

2012-06-21 Thread Gang Tim Liu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398254#comment-13398254 ] Gang Tim Liu commented on HIVE-3165: @Carl, let me check. thanks a lot

[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate quality hashCode()

2012-06-21 Thread Carl Steinbach (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398249#comment-13398249 ] Carl Steinbach commented on HIVE-3165: -- +1. Will commit if tests pass.

[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate quality hashCode()

2012-06-21 Thread Gang Tim Liu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398238#comment-13398238 ] Gang Tim Liu commented on HIVE-3165: Patch is attached to here also. >

[jira] [Commented] (HIVE-3165) Hive thrift code doesnt generate quality hashCode()

2012-06-21 Thread Gang Tim Liu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398233#comment-13398233 ] Gang Tim Liu commented on HIVE-3165: patch is available for review https://reviews.face