[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057194#comment-14057194
]
Jason Dere commented on HIVE-3392:
--
Left comment on RB, which I think is causing the
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057211#comment-14057211
]
Navis commented on HIVE-3392:
-
Rebased to trunk and fixed that. Thanks.
Hive unnecessarily
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057275#comment-14057275
]
Jason Dere commented on HIVE-3392:
--
+1 if tests pass ok.
Hive unnecessarily validates
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057330#comment-14057330
]
Hive QA commented on HIVE-3392:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056017#comment-14056017
]
Hive QA commented on HIVE-3392:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057083#comment-14057083
]
Jason Dere commented on HIVE-3392:
--
So this moves the validity check from getTable(), over
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057148#comment-14057148
]
Navis commented on HIVE-3392:
-
Basically get the same exception(CNE) but with different
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040579#comment-14040579
]
Ashutosh Chauhan commented on HIVE-3392:
I am fine with reopening this.
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040802#comment-14040802
]
Edward Capriolo commented on HIVE-3392:
---
Please feel free to take over the review. I
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031705#comment-14031705
]
Hive QA commented on HIVE-3392:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14027293#comment-14027293
]
Navis commented on HIVE-3392:
-
If it's non-native table with custom storage handler, it's right
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13498660#comment-13498660
]
Ajesh Kumar commented on HIVE-3392:
---
Hi Edward Capriolo
As per my previous comment, can
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13492219#comment-13492219
]
Ajesh Kumar commented on HIVE-3392:
---
Hi Edward Capriolo/Namit
As per my previous comment,
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13492861#comment-13492861
]
Edward Capriolo commented on HIVE-3392:
---
Sorry I have not had a chance to to a full
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13473103#comment-13473103
]
Ajesh Kumar commented on HIVE-3392:
---
Hi Edward Capriolo,
So can we conclude this as not
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13473612#comment-13473612
]
Edward Capriolo commented on HIVE-3392:
---
Yes. I think a nice clean exception / error
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464739#comment-13464739
]
Edward Capriolo commented on HIVE-3392:
---
Ajesh. Please address my comments
1 why do
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464804#comment-13464804
]
Ajesh Kumar commented on HIVE-3392:
---
Hi Edward Capriolo,
when we are dropping a table,
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464926#comment-13464926
]
Edward Capriolo commented on HIVE-3392:
---
Because some Serde's NEED to do custom
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463858#comment-13463858
]
Ajesh Kumar commented on HIVE-3392:
---
Hi Namit,
Do I need to change Assignee to get this
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13454625#comment-13454625
]
Ajesh Kumar commented on HIVE-3392:
---
Hi Edward Capriolo, when we are dropping a table,
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13454626#comment-13454626
]
Ajesh Kumar commented on HIVE-3392:
---
Testcases are attached.
1) HIVE-3392.Test Case -
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452747#comment-13452747
]
Namit Jain commented on HIVE-3392:
--
[~ajeshpg], I have added you as a contributor. You can
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13453714#comment-13453714
]
Namit Jain commented on HIVE-3392:
--
comments
[~ajeshpg], please mark 'submit patch' when
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13453715#comment-13453715
]
Edward Capriolo commented on HIVE-3392:
---
I have an issue with this. Serde's and
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13451895#comment-13451895
]
Ajesh Kumar commented on HIVE-3392:
---
All DDL statement are calling Hive.getTable() method
[
https://issues.apache.org/jira/browse/HIVE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452722#comment-13452722
]
Ajesh Kumar commented on HIVE-3392:
---
Review request added at
27 matches
Mail list logo