[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640579#comment-13640579
]
Hudson commented on HIVE-3891:
--
Integrated in Hive-trunk-hadoop2 #173 (See
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638973#comment-13638973
]
Namit Jain commented on HIVE-3891:
--
comments
physical optimizer changes
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640104#comment-13640104
]
Hudson commented on HIVE-3891:
--
Integrated in Hive-trunk-h0.21 #2076 (See
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637908#comment-13637908
]
Namit Jain commented on HIVE-3891:
--
Refreshed, addressed comments, ran tests.
Can you take
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635005#comment-13635005
]
Namit Jain commented on HIVE-3891:
--
[~ashutoshc], all the tests passed. Since this was
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635660#comment-13635660
]
Ashutosh Chauhan commented on HIVE-3891:
Left some comments on Phabricator.
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632730#comment-13632730
]
Namit Jain commented on HIVE-3891:
--
refreshing again and resolving conflicts
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628782#comment-13628782
]
Namit Jain commented on HIVE-3891:
--
[~ashutoshc], will do
physical
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628814#comment-13628814
]
Namit Jain commented on HIVE-3891:
--
I am refreshing https://reviews.facebook.net/D8439
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628836#comment-13628836
]
Namit Jain commented on HIVE-3891:
--
[~ashutoshc], it might be a good idea to get
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628844#comment-13628844
]
Namit Jain commented on HIVE-3891:
--
Otherwise, the refreshed patch looks good.
Can you
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607676#comment-13607676
]
Ashutosh Chauhan commented on HIVE-3891:
+1 running tests.
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13608334#comment-13608334
]
Ashutosh Chauhan commented on HIVE-3891:
Test auto_sortmerge_join_9.q failed,
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13593003#comment-13593003
]
Vikram Dixit K commented on HIVE-3891:
--
+1 (non-binding) for this patch.
Raised
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13589373#comment-13589373
]
Namit Jain commented on HIVE-3891:
--
Yes, that is true even before my patch
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13589374#comment-13589374
]
Namit Jain commented on HIVE-3891:
--
I verified the last query in the attached file in
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590221#comment-13590221
]
Vikram Dixit K commented on HIVE-3891:
--
What I mean is right aliases can be only 1
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590224#comment-13590224
]
Namit Jain commented on HIVE-3891:
--
The review request is there :
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590231#comment-13590231
]
Namit Jain commented on HIVE-3891:
--
I dont see any change in AbstractSMBJoinProc in this
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590232#comment-13590232
]
Vikram Dixit K commented on HIVE-3891:
--
Hey Namit,
I thought that this was the patch
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590233#comment-13590233
]
Namit Jain commented on HIVE-3891:
--
I didn't understand your case.
A join B on A.key =
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590234#comment-13590234
]
Namit Jain commented on HIVE-3891:
--
Both of them should work.
physical
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590250#comment-13590250
]
Vikram Dixit K commented on HIVE-3891:
--
Hi Namit,
The test case I have is very
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590262#comment-13590262
]
Vikram Dixit K commented on HIVE-3891:
--
I think all this needs is
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590294#comment-13590294
]
Namit Jain commented on HIVE-3891:
--
canConvertJoinToBucketMapJoin:
The join should be
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590295#comment-13590295
]
Namit Jain commented on HIVE-3891:
--
This is a existing bug, and we need to debug this, but
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13589253#comment-13589253
]
Namit Jain commented on HIVE-3891:
--
[~vikram.dixit], I am confused.
Look at line 965 of
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13587961#comment-13587961
]
Vikram Dixit K commented on HIVE-3891:
--
Hi Namit,
In case of the test
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13581223#comment-13581223
]
Namit Jain commented on HIVE-3891:
--
The tests passed
physical optimizer
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573343#comment-13573343
]
Namit Jain commented on HIVE-3891:
--
https://reviews.facebook.net/D8439
[
https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573240#comment-13573240
]
Namit Jain commented on HIVE-3891:
--
After HIVE-3403, an auto sortmerge join can be
31 matches
Mail list logo