[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-04-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640579#comment-13640579 ] Hudson commented on HIVE-3891: -- Integrated in Hive-trunk-hadoop2 #173 (See

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-04-23 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638973#comment-13638973 ] Namit Jain commented on HIVE-3891: -- comments physical optimizer changes

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-04-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640104#comment-13640104 ] Hudson commented on HIVE-3891: -- Integrated in Hive-trunk-h0.21 #2076 (See

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-04-22 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637908#comment-13637908 ] Namit Jain commented on HIVE-3891: -- Refreshed, addressed comments, ran tests. Can you take

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-04-18 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635005#comment-13635005 ] Namit Jain commented on HIVE-3891: -- [~ashutoshc], all the tests passed. Since this was

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-04-18 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635660#comment-13635660 ] Ashutosh Chauhan commented on HIVE-3891: Left some comments on Phabricator.

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-04-16 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632730#comment-13632730 ] Namit Jain commented on HIVE-3891: -- refreshing again and resolving conflicts

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-04-11 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628782#comment-13628782 ] Namit Jain commented on HIVE-3891: -- [~ashutoshc], will do physical

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-04-11 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628814#comment-13628814 ] Namit Jain commented on HIVE-3891: -- I am refreshing https://reviews.facebook.net/D8439

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-04-11 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628836#comment-13628836 ] Namit Jain commented on HIVE-3891: -- [~ashutoshc], it might be a good idea to get

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-04-11 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628844#comment-13628844 ] Namit Jain commented on HIVE-3891: -- Otherwise, the refreshed patch looks good. Can you

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-03-20 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607676#comment-13607676 ] Ashutosh Chauhan commented on HIVE-3891: +1 running tests.

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-03-20 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13608334#comment-13608334 ] Ashutosh Chauhan commented on HIVE-3891: Test auto_sortmerge_join_9.q failed,

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-03-04 Thread Vikram Dixit K (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13593003#comment-13593003 ] Vikram Dixit K commented on HIVE-3891: -- +1 (non-binding) for this patch. Raised

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-28 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13589373#comment-13589373 ] Namit Jain commented on HIVE-3891: -- Yes, that is true even before my patch

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-28 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13589374#comment-13589374 ] Namit Jain commented on HIVE-3891: -- I verified the last query in the attached file in

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-28 Thread Vikram Dixit K (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590221#comment-13590221 ] Vikram Dixit K commented on HIVE-3891: -- What I mean is right aliases can be only 1

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-28 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590224#comment-13590224 ] Namit Jain commented on HIVE-3891: -- The review request is there :

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-28 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590231#comment-13590231 ] Namit Jain commented on HIVE-3891: -- I dont see any change in AbstractSMBJoinProc in this

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-28 Thread Vikram Dixit K (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590232#comment-13590232 ] Vikram Dixit K commented on HIVE-3891: -- Hey Namit, I thought that this was the patch

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-28 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590233#comment-13590233 ] Namit Jain commented on HIVE-3891: -- I didn't understand your case. A join B on A.key =

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-28 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590234#comment-13590234 ] Namit Jain commented on HIVE-3891: -- Both of them should work. physical

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-28 Thread Vikram Dixit K (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590250#comment-13590250 ] Vikram Dixit K commented on HIVE-3891: -- Hi Namit, The test case I have is very

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-28 Thread Vikram Dixit K (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590262#comment-13590262 ] Vikram Dixit K commented on HIVE-3891: -- I think all this needs is

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-28 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590294#comment-13590294 ] Namit Jain commented on HIVE-3891: -- canConvertJoinToBucketMapJoin: The join should be

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-28 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590295#comment-13590295 ] Namit Jain commented on HIVE-3891: -- This is a existing bug, and we need to debug this, but

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-27 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13589253#comment-13589253 ] Namit Jain commented on HIVE-3891: -- [~vikram.dixit], I am confused. Look at line 965 of

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-26 Thread Vikram Dixit K (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13587961#comment-13587961 ] Vikram Dixit K commented on HIVE-3891: -- Hi Namit, In case of the test

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-19 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13581223#comment-13581223 ] Namit Jain commented on HIVE-3891: -- The tests passed physical optimizer

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-07 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573343#comment-13573343 ] Namit Jain commented on HIVE-3891: -- https://reviews.facebook.net/D8439

[jira] [Commented] (HIVE-3891) physical optimizer changes for auto sort-merge join

2013-02-06 Thread Namit Jain (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573240#comment-13573240 ] Namit Jain commented on HIVE-3891: -- After HIVE-3403, an auto sortmerge join can be