[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742863#comment-13742863 ] Hudson commented on HIVE-4838: -- ABORTED: Integrated in Hive-trunk-hadoop2 #365 (See

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742184#comment-13742184 ] Brock Noland commented on HIVE-4838: Done, looks like the last build had a connection

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742310#comment-13742310 ] Hive QA commented on HIVE-4838: --- {color:red}Overall{color}: -1 at least one tests failed

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742316#comment-13742316 ] Brock Noland commented on HIVE-4838: That test has been failing since commit. I believe

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742343#comment-13742343 ] Brock Noland commented on HIVE-4838: Thanks!! I have opened HIVE-5110 to look at the

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742550#comment-13742550 ] Hudson commented on HIVE-4838: -- FAILURE: Integrated in Hive-trunk-hadoop2-ptest #61 (See

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742622#comment-13742622 ] Hudson commented on HIVE-4838: -- FAILURE: Integrated in Hive-trunk-hadoop1-ptest #130 (See

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742851#comment-13742851 ] Hudson commented on HIVE-4838: -- FAILURE: Integrated in Hive-trunk-h0.21 #2273 (See

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13741882#comment-13741882 ] Ashutosh Chauhan commented on HIVE-4838: [~brocknoland] Can you trigger HIVE QA run

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737471#comment-13737471 ] Ashutosh Chauhan commented on HIVE-4838: Good work Brock. Left some comments on

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737482#comment-13737482 ] Brock Noland commented on HIVE-4838: Sounds good, I will address them. In regards to

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737492#comment-13737492 ] Ashutosh Chauhan commented on HIVE-4838: Ok. Sounds good.

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735785#comment-13735785 ] Ashutosh Chauhan commented on HIVE-4838: [~brocknoland] Lets get this in, before

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735950#comment-13735950 ] Brock Noland commented on HIVE-4838: Good call, I will make the change tonight and

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736168#comment-13736168 ] Hive QA commented on HIVE-4838: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13732293#comment-13732293 ] Ashutosh Chauhan commented on HIVE-4838: Actually memory monitoring I was talking

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13732571#comment-13732571 ] Brock Noland commented on HIVE-4838: What I was saying is the the local task JVM could

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13732597#comment-13732597 ] Ashutosh Chauhan commented on HIVE-4838: bq. I am fine with removing the memory

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726497#comment-13726497 ] Ashutosh Chauhan commented on HIVE-4838: bq. The current code is using this static

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726507#comment-13726507 ] Brock Noland commented on HIVE-4838: Hey can you explain a little bit more? We aren't

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726791#comment-13726791 ] Ashutosh Chauhan commented on HIVE-4838: Yeah I misunderstood that piece. Another

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727102#comment-13727102 ] Brock Noland commented on HIVE-4838: I guess we could go that route. My thought was

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13723403#comment-13723403 ] Edward Capriolo commented on HIVE-4838: --- Hey, I think I may have mistakenly come to

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13717703#comment-13717703 ] Ashutosh Chauhan commented on HIVE-4838: [~brocknoland] One of the item listed in

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13717716#comment-13717716 ] Brock Noland commented on HIVE-4838: Hey, Yes I have. I'll upload an updated patch

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13717719#comment-13717719 ] Brock Noland commented on HIVE-4838: Updated review https://reviews.facebook.net/D11679

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707751#comment-13707751 ] Brock Noland commented on HIVE-4838: Correct I believe this to only affect the null

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707154#comment-13707154 ] Ashutosh Chauhan commented on HIVE-4838: I see there is an update to .q.out file.

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707181#comment-13707181 ] Brock Noland commented on HIVE-4838: Hi, Correct there is. It's related to the snippet

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707205#comment-13707205 ] Ashutosh Chauhan commented on HIVE-4838: Interesting. Lets tease out that part from

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707213#comment-13707213 ] Brock Noland commented on HIVE-4838: Fair enough, I'll have a patch for HIVE-4845

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707239#comment-13707239 ] Edward Capriolo commented on HIVE-4838: --- So which version is correct the map join or

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707269#comment-13707269 ] Brock Noland commented on HIVE-4838: Map-side is wrong and reduce-side was correct. For

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707318#comment-13707318 ] Edward Capriolo commented on HIVE-4838: --- This is pretty sad news. How long has

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707332#comment-13707332 ] Brock Noland commented on HIVE-4838: I think the equals method has been broken since

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707592#comment-13707592 ] Yin Huai commented on HIVE-4838: Hi Brock, I have a question. Does this correctness issue

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707658#comment-13707658 ] Yin Huai commented on HIVE-4838: From the code, seems this issue only affects = operator.

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13704832#comment-13704832 ] Ashutosh Chauhan commented on HIVE-4838: I am glad you are taking a stab at this

[jira] [Commented] (HIVE-4838) Refactor MapJoin HashMap code to improve testability and readability

[ https://issues.apache.org/jira/browse/HIVE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705401#comment-13705401 ] Brock Noland commented on HIVE-4838: Hey thanks for the feedback! Yes I thought about