[
https://issues.apache.org/jira/browse/HIVE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119383#comment-13119383
]
jirapos...@reviews.apache.org commented on HIVE-619:
[
https://issues.apache.org/jira/browse/HIVE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119472#comment-13119472
]
John Sichi commented on HIVE-619:
-
+1. Will commit when tests pass.
[
https://issues.apache.org/jira/browse/HIVE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119774#comment-13119774
]
John Sichi commented on HIVE-619:
-
I got failures in existing tests
[
https://issues.apache.org/jira/browse/HIVE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119790#comment-13119790
]
jirapos...@reviews.apache.org commented on HIVE-619:
[
https://issues.apache.org/jira/browse/HIVE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119813#comment-13119813
]
John Sichi commented on HIVE-619:
-
I'll re-run tests with latest.
Change
[
https://issues.apache.org/jira/browse/HIVE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118375#comment-13118375
]
jirapos...@reviews.apache.org commented on HIVE-619:
[
https://issues.apache.org/jira/browse/HIVE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117480#comment-13117480
]
jirapos...@reviews.apache.org commented on HIVE-619:
[
https://issues.apache.org/jira/browse/HIVE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117537#comment-13117537
]
John Sichi commented on HIVE-619:
-
1) Need to cover the case where the class exists, but is