[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-10-16 Thread Yin Huai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173804#comment-14173804 ] Yin Huai commented on HIVE-7205: [~navis] Can you update the review board? I will take a lo

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-10-06 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160067#comment-14160067 ] Hive QA commented on HIVE-7205: --- {color:red}Overall{color}: -1 at least one tests failed H

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-08-11 Thread Yin Huai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093129#comment-14093129 ] Yin Huai commented on HIVE-7205: Yeah, fixing correctness bug is very important. However,

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-08-10 Thread Navis (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092308#comment-14092308 ] Navis commented on HIVE-7205: - [~ashutoshc] IMO, [~yhuai] is original author of this optimizer

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-08-09 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091974#comment-14091974 ] Ashutosh Chauhan commented on HIVE-7205: [~yhuai] Since this is correctness issue,

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-08-03 Thread Yin Huai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084215#comment-14084215 ] Yin Huai commented on HIVE-7205: Oh, I see. In the current patch, "isLastInput" takes speci

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-08-03 Thread Yin Huai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084158#comment-14084158 ] Yin Huai commented on HIVE-7205: My main concern is that because we use the right most tabl

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-08-01 Thread Yin Huai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082384#comment-14082384 ] Yin Huai commented on HIVE-7205: No yet. I will try to find sometime during the weekend. >

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-07-31 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081960#comment-14081960 ] Ashutosh Chauhan commented on HIVE-7205: [~yhuai] Did you get a chance to look at t

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-07-21 Thread Navis (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069647#comment-14069647 ] Navis commented on HIVE-7205: - Sorry for late reply. In operator, there are startGroup()/endG

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-07-13 Thread Yin Huai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060383#comment-14060383 ] Yin Huai commented on HIVE-7205: [~navis] Thank you for the patch. I have left some comment

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-07-08 Thread Navis (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054599#comment-14054599 ] Navis commented on HIVE-7205: - [~yhuai] Good! Take your time. > Wrong results when union all o

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-07-07 Thread Yin Huai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054454#comment-14054454 ] Yin Huai commented on HIVE-7205: [~navis] Simplifying interactions between operators is goo

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-07-07 Thread Navis (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054383#comment-14054383 ] Navis commented on HIVE-7205: - [~yhuai] Exactly. I regret I've done too much modifications with

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-07-07 Thread Yin Huai (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054303#comment-14054303 ] Yin Huai commented on HIVE-7205: Sure. I will take a look at it. Seems the issue is that t

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-07-07 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053867#comment-14053867 ] Ashutosh Chauhan commented on HIVE-7205: [~yhuai] Can you review this one? > Wrong

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-07-03 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051489#comment-14051489 ] Hive QA commented on HIVE-7205: --- {color:red}Overall{color}: -1 at least one tests failed H

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-07-01 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049060#comment-14049060 ] Hive QA commented on HIVE-7205: --- {color:red}Overall{color}: -1 at least one tests failed H

[jira] [Commented] (HIVE-7205) Wrong results when union all of grouping followed by group by with correlation optimization

2014-06-20 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039506#comment-14039506 ] Hive QA commented on HIVE-7205: --- {color:red}Overall{color}: -1 at least one tests failed H