[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173804#comment-14173804
]
Yin Huai commented on HIVE-7205:
[~navis] Can you update the review board? I will take a lo
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160067#comment-14160067
]
Hive QA commented on HIVE-7205:
---
{color:red}Overall{color}: -1 at least one tests failed
H
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093129#comment-14093129
]
Yin Huai commented on HIVE-7205:
Yeah, fixing correctness bug is very important.
However,
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092308#comment-14092308
]
Navis commented on HIVE-7205:
-
[~ashutoshc] IMO, [~yhuai] is original author of this optimizer
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091974#comment-14091974
]
Ashutosh Chauhan commented on HIVE-7205:
[~yhuai] Since this is correctness issue,
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084215#comment-14084215
]
Yin Huai commented on HIVE-7205:
Oh, I see. In the current patch, "isLastInput" takes speci
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084158#comment-14084158
]
Yin Huai commented on HIVE-7205:
My main concern is that because we use the right most tabl
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082384#comment-14082384
]
Yin Huai commented on HIVE-7205:
No yet. I will try to find sometime during the weekend.
>
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081960#comment-14081960
]
Ashutosh Chauhan commented on HIVE-7205:
[~yhuai] Did you get a chance to look at t
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069647#comment-14069647
]
Navis commented on HIVE-7205:
-
Sorry for late reply.
In operator, there are startGroup()/endG
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060383#comment-14060383
]
Yin Huai commented on HIVE-7205:
[~navis] Thank you for the patch. I have left some comment
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054599#comment-14054599
]
Navis commented on HIVE-7205:
-
[~yhuai] Good! Take your time.
> Wrong results when union all o
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054454#comment-14054454
]
Yin Huai commented on HIVE-7205:
[~navis] Simplifying interactions between operators is goo
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054383#comment-14054383
]
Navis commented on HIVE-7205:
-
[~yhuai] Exactly. I regret I've done too much modifications with
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054303#comment-14054303
]
Yin Huai commented on HIVE-7205:
Sure. I will take a look at it.
Seems the issue is that t
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053867#comment-14053867
]
Ashutosh Chauhan commented on HIVE-7205:
[~yhuai] Can you review this one?
> Wrong
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051489#comment-14051489
]
Hive QA commented on HIVE-7205:
---
{color:red}Overall{color}: -1 at least one tests failed
H
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049060#comment-14049060
]
Hive QA commented on HIVE-7205:
---
{color:red}Overall{color}: -1 at least one tests failed
H
[
https://issues.apache.org/jira/browse/HIVE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039506#comment-14039506
]
Hive QA commented on HIVE-7205:
---
{color:red}Overall{color}: -1 at least one tests failed
H
19 matches
Mail list logo