[
https://issues.apache.org/jira/browse/HIVE-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049625#comment-14049625
]
Brock Noland commented on HIVE-7291:
+1
Refactor TestParser to understand
[
https://issues.apache.org/jira/browse/HIVE-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048402#comment-14048402
]
Szehon Ho commented on HIVE-7291:
-
Yea that test is to manually (eyeball) the output of
[
https://issues.apache.org/jira/browse/HIVE-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048405#comment-14048405
]
Brock Noland commented on HIVE-7291:
Yeah I agree we should throw an
[
https://issues.apache.org/jira/browse/HIVE-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046925#comment-14046925
]
Brock Noland commented on HIVE-7291:
I see the test `testParseFile` is commented out?
[
https://issues.apache.org/jira/browse/HIVE-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14045703#comment-14045703
]
Szehon Ho commented on HIVE-7291:
-
That first comment auto-formatted strangely, writing the
[
https://issues.apache.org/jira/browse/HIVE-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14046712#comment-14046712
]
Brock Noland commented on HIVE-7291:
I'll look at this some but it looks good! Thx