[jira] [Commented] (HIVE-8518) Compile time skew join optimization returns duplicated results

2014-10-21 Thread Brock Noland (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179538#comment-14179538 ] Brock Noland commented on HIVE-8518: lgtm as well. Thank you!! > Compile time skew joi

[jira] [Commented] (HIVE-8518) Compile time skew join optimization returns duplicated results

2014-10-21 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179517#comment-14179517 ] Rui Li commented on HIVE-8518: -- Thanks [~xuefuz] and [~brocknoland]! Everything seems fine fro

[jira] [Commented] (HIVE-8518) Compile time skew join optimization returns duplicated results

2014-10-21 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179500#comment-14179500 ] Xuefu Zhang commented on HIVE-8518: --- Merged. Not sure if I screwed up anything though. >

[jira] [Commented] (HIVE-8518) Compile time skew join optimization returns duplicated results

2014-10-21 Thread Brock Noland (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179484#comment-14179484 ] Brock Noland commented on HIVE-8518: There is some results difference s that I cannot a

[jira] [Commented] (HIVE-8518) Compile time skew join optimization returns duplicated results

2014-10-21 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179483#comment-14179483 ] Rui Li commented on HIVE-8518: -- OK got it. > Compile time skew join optimization returns dupl

[jira] [Commented] (HIVE-8518) Compile time skew join optimization returns duplicated results

2014-10-21 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179480#comment-14179480 ] Xuefu Zhang commented on HIVE-8518: --- I think [~brocknoland] is in the middle of merging t

[jira] [Commented] (HIVE-8518) Compile time skew join optimization returns duplicated results

2014-10-21 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179446#comment-14179446 ] Rui Li commented on HIVE-8518: -- Thank you [~xuefuz] for the review! Could you also merge this

[jira] [Commented] (HIVE-8518) Compile time skew join optimization returns duplicated results

2014-10-21 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178998#comment-14178998 ] Xuefu Zhang commented on HIVE-8518: --- This would be a good candidate for 0.14 also. > Com

[jira] [Commented] (HIVE-8518) Compile time skew join optimization returns duplicated results

2014-10-20 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177840#comment-14177840 ] Xuefu Zhang commented on HIVE-8518: --- Okay. Thanks for the explanation. +1 > Compile tim

[jira] [Commented] (HIVE-8518) Compile time skew join optimization returns duplicated results

2014-10-20 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177807#comment-14177807 ] Rui Li commented on HIVE-8518: -- Hi [~xuefuz], I find there're already several unit tests for c

[jira] [Commented] (HIVE-8518) Compile time skew join optimization returns duplicated results

2014-10-20 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177061#comment-14177061 ] Xuefu Zhang commented on HIVE-8518: --- [~ruili], patch looks good. I'm wondering if it make

[jira] [Commented] (HIVE-8518) Compile time skew join optimization returns duplicated results

2014-10-20 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176961#comment-14176961 ] Hive QA commented on HIVE-8518: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-8518) Compile time skew join optimization returns duplicated results

2014-10-20 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176755#comment-14176755 ] Rui Li commented on HIVE-8518: -- cc [~xuefuz] > Compile time skew join optimization returns du