[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202126#comment-14202126 ] Owen O'Malley commented on HIVE-8732: - I should also point out that I added a line to

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202230#comment-14202230 ] Prasanth J commented on HIVE-8732: -- I have verified that file version in file dump with

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1416#comment-1416 ] Hive QA commented on HIVE-8732: --- {color:red}Overall{color}: -1 at least one tests failed

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201442#comment-14201442 ] Prasanth J commented on HIVE-8732: -- The new changes looks good to me. +1. Can you create a

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201628#comment-14201628 ] Hive QA commented on HIVE-8732: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201738#comment-14201738 ] Gunther Hagleitner commented on HIVE-8732: -- +1 for hive .14 ORC string

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197848#comment-14197848 ] Hive QA commented on HIVE-8732: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199199#comment-14199199 ] Owen O'Malley commented on HIVE-8732: - I've created the timestamp bug as HIVE-8746. The

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199268#comment-14199268 ] Dain Sundstrom commented on HIVE-8732: -- How will the code know that the stripe/file

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199353#comment-14199353 ] Dain Sundstrom commented on HIVE-8732: -- DoubleStatisticsImpl merge and update methods

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199460#comment-14199460 ] Dain Sundstrom commented on HIVE-8732: -- This seems like a reasonable plan. ORC

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199468#comment-14199468 ] Dain Sundstrom commented on HIVE-8732: -- The patch looks reasonable. We still need

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14196843#comment-14196843 ] Dain Sundstrom commented on HIVE-8732: -- Decimal and Date are also broken ORC string

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14196847#comment-14196847 ] Owen O'Malley commented on HIVE-8732: - Timestamp too. *sigh* ORC string statistics

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197045#comment-14197045 ] Prasanth J commented on HIVE-8732: -- LGTM, +1. Pending tests ORC string statistics are

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197280#comment-14197280 ] Dain Sundstrom commented on HIVE-8732: -- The test cover a.merge(b) where is wider, but

[jira] [Commented] (HIVE-8732) ORC string statistics are not merged correctly

[ https://issues.apache.org/jira/browse/HIVE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197283#comment-14197283 ] Dain Sundstrom commented on HIVE-8732: -- You will need to bump the file version so a