[
https://issues.apache.org/jira/browse/HIVE-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12971514#action_12971514
]
Devaraj Das commented on HIVE-842:
--
Thanks Yongqiang for reviewing. Writing a testcase is
[
https://issues.apache.org/jira/browse/HIVE-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12971515#action_12971515
]
He Yongqiang commented on HIVE-842:
---
Will run tests and commit.
Authentication
[
https://issues.apache.org/jira/browse/HIVE-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12971518#action_12971518
]
Ashutosh Chauhan commented on HIVE-842:
---
I ran the existing tests and they succeeded
[
https://issues.apache.org/jira/browse/HIVE-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12971130#action_12971130
]
Devaraj Das commented on HIVE-842:
--
The security related changes look fine to me.
[
https://issues.apache.org/jira/browse/HIVE-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12969862#action_12969862
]
Ashutosh Chauhan commented on HIVE-842:
---
HIVE-1526 went in. This is ready to go in as
[
https://issues.apache.org/jira/browse/HIVE-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12969866#action_12969866
]
John Sichi commented on HIVE-842:
-
Click Submit Patch to get it into the review queue.
[
https://issues.apache.org/jira/browse/HIVE-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12969881#action_12969881
]
He Yongqiang commented on HIVE-842:
---
will take a look.
Authentication Infrastructure for
[
https://issues.apache.org/jira/browse/HIVE-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12932210#action_12932210
]
Pradeep Kamath commented on HIVE-842:
-
I have tested this patch after making HIVE-1526
[
https://issues.apache.org/jira/browse/HIVE-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12924034#action_12924034
]
Todd Lipcon commented on HIVE-842:
--
Hey Pradeep. Those changes seem reasonable. I'm not