Re: HIVE-5104 patch status?

2013-09-04 Thread Brock Noland
Hi, Looks like your patch has been committed, but I just wanted to confirm for those lurking. If you have a patch up on a JIRA, emailing the dev list is one of the correct ways of engaging a committer. IRC is also a viable strategy. Thanks for your contribution!! Cheers, Brock On Tue, Sep 3,

Re: HIVE-5104 patch status?

2013-09-04 Thread Edward Capriolo
I'm not sure I understand what you are saying I see plenty of comments on your ticket. http://www.apache.org/dev/committers.html#committer-responsibilities Applying patches In order to grow and maintain healthy communities, committers need to discuss, review and apply patches submitted by

Re: HIVE-5104 patch status?

2013-09-04 Thread Sushanth Sowmyan
Hi Karl, Looks like we crossed streams. :) I started reviewing your patch last thursday, and committed it yesterday. I had to run some tests before incorporating your patch. I did initially comment up asking for patch regeneration since your patch did not apply cleanly for me on trunk, and also

HIVE-5104 patch status?

2013-09-03 Thread Karl Gierach
Hi, We at Sourcethought have contributed at patch to fix JIRA issue HIVE-5104 about 2 weeks back, although it appears that this patch has not received any comments. The patch is relevant for the both github Hive branch-0.11 and the trunk, as both source files were not changed since the 0.11