Re: Please double-check JIRA number on commit

Perhaps we need a comments column for issues that aren't wrong-JIRA-numbers. For example, HIVE-11536 which just got added to the list (commit b22e54ecec96d1b86fea1b53dae4c8bb68a11f9c). The errata.txt file says "Commits with the wrong JIRA referen

Re: Please double-check JIRA number on commit

Ok, I've created a patch with Lefty's items. Please take a look: https://issues.apache.org/jira/browse/HIVE-11704

Re: Please double-check JIRA number on commit

+1 to putting it in source. We could start an "errata" file or something that lists these. Alan. Lefty Leverenz August 29, 2015 at 22:45 One more for the list of commits that don't have the right JIRA issue number -- but in this case, it doesn't have any issue

Re: Please double-check JIRA number on commit

Sorry, I forgot to include a JIRA number for HIVE-10021. Thanks Lefty for finding out. I wish there's a way to fix this. Best, Chao On Sat, Aug 29, 2015 at 10:45 PM, Lefty Leverenz wrote: > One more for the list of commits that don't have the right JIRA issue > number -- but in this case, it do

Re: Please double-check JIRA number on commit

One more for the list of commits that don't have the right JIRA issue number -- but in this case, it doesn't have any issue number: - dcf21cd6fa98fb5db01ef661bb3b9f94d9ca2d15 HIVE-10021 Do we want to put the list into the source tree? --

Re: Please double-check JIRA number on commit

Here are the ones I know about: - 5a576b6fbf1680ab4dd8f275cad484a2614ef2c1 HIVE-10391 - 582f4e1bc39b9605d11f762480b29561a44688ae HIVE-10217 - 8981f365bf0cf921bc0ac2ff8914df44ca2f7

Re: Please double-check JIRA number on commit

Good idea! I'll compile a list. -- Lefty On Sat, Jun 6, 2015 at 9:00 AM, Owen O'Malley wrote: > Editing commits creates a lot of problems. May I suggest that we start a > file that lists the exceptions that you've noticed and check that into our > source tree? That will give everyone access to

Re: Please double-check JIRA number on commit

Editing commits creates a lot of problems. May I suggest that we start a file that lists the exceptions that you've noticed and check that into our source tree? That will give everyone access to fix things when they recognize it. It would look like: 75b679c54c9088434678da2a4d89122620903d72 hive-12

Re: Please double-check JIRA number on commit

> > ... we should put the commit log in the corresponding > JIRA comment as a cross-reference. > I've only noticed one more slip-up since the end of April, but still think this is a good idea. Any more suggestions? -- Lefty On Thu, Apr 30, 2015 at 4:53 PM, Xuefu Zhang wrote: > Yes, for that,

Re: Please double-check JIRA number on commit

Yes, for that, I think we should put the commit log in the corresponding JIRA comment as a cross-reference. I have to admit that I had to fix commit message for a few of my svn commits in the past. On Thu, Apr 30, 2015 at 3:53 PM, Lefty Leverenz wrote: > Found a negative answer to #2 in some ASF

Re: Please double-check JIRA number on commit

Found a negative answer to #2 in some ASF instructions for security issues (*underline added*): 15. The log for the svn commit that applied the fix is updated to include > the CVE number. Projects that use git as their primary source code control >

Please double-check JIRA number on commit

Since switching to git, three commits have had the wrong JIRA number. Two were typos and the third one gave the umbrella issue's number. Fortunately the correct issue could be found by searching for the summary text. 1. How can we reduce this failure rate? 2. Can JIRA numbers be fixed afte