Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review203121 --- Ship it! +1 pending tests - Peter Vary On May 14, 2018,

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/ --- (Updated May 14, 2018, 8:07 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review203035 --- I think you are safe to use the Java 8 specific method rather

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

> On May 11, 2018, 10:32 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Lines 2334 (patched) > > > > > > Is it possible to end up with overflowed long? You can use Java8 method.

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/ --- (Updated May 12, 2018, 12:30 a.m.) Review request for hive, Sahil Takiar and

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review202911 --- All of my other comments are fixed. Thanks, Peter

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/ --- (Updated May 10, 2018, 10:51 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

> On May 7, 2018, 6:07 p.m., Bharathkrishna Guruvayoor Murali wrote: > > Added new version of patch. > > Adding the result as "Unknown rows affected" for return value -1 from > > beeline. > > Fixing test failures, and modifying tests to accommodate the change. > > Further changes in this

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review202835 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/ --- (Updated May 9, 2018, 8:46 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

> On May 8, 2018, 10:42 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java > > Lines 430-439 (patched) > > > > > > Why did you moved this inside the if statement?

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review202625 --- Almost there. Mostly just formatting questions, so you will have

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review202561 --- Added new version of patch. Adding the result as "Unknown rows

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/ --- (Updated May 7, 2018, 5:58 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review202193 --- Fix it, then Ship it! One minor comment, otherwise LGTM.

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/ --- (Updated April 27, 2018, 11:05 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review202009 --- jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java Line 712

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

> On March 27, 2018, 12:53 p.m., Peter Vary wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java > > Line 712 (original), 712 (patched) > > > > > > Is it possible to behave differently, when we have

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/ --- (Updated April 23, 2018, 9:56 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

- Bharathkrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review201637 --- On April 18, 2018, 11:53 p.m., Bharathkrishna

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

- Bharathkrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review200042 --- On April 18, 2018, 11:53 p.m., Bharathkrishna

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

> On March 27, 2018, 12:53 p.m., Peter Vary wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java > > Line 712 (original), 712 (patched) > > > > > > Is it possible to behave differently, when we have

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

> On April 20, 2018, 4:34 p.m., Sahil Takiar wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java > > Line 711 (original), 711 (patched) > > > > > > why change the method call? don't both methods return

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

> On March 27, 2018, 12:53 p.m., Peter Vary wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java > > Line 712 (original), 712 (patched) > > > > > > Is it possible to behave differently, when we have

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review201637 --- jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java Line 711

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/ --- (Updated April 18, 2018, 11:53 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

> On March 27, 2018, 12:53 p.m., Peter Vary wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java > > Line 712 (original), 712 (patched) > > > > > > Is it possible to behave differently, when we have

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review200042 --- Hi Bharathkrishna, This is a long missing feature. Thanks for