Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-30 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/ --- (Updated Oct. 30, 2012, 6:39 p.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-29 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/ --- (Updated Oct. 30, 2012, 1:24 a.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-21 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/#review12216 --- ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.jav

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-21 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/ --- (Updated Oct. 22, 2012, 6:27 a.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-05 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/#review12203 --- ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.jav

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-03 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/ --- (Updated Oct. 4, 2012, 5:45 a.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-03 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/ --- (Updated Oct. 3, 2012, 7:16 p.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-03 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/ --- (Updated Oct. 3, 2012, 7:16 p.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-03 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/#review12137 --- ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-03 Thread Shreepadma Venugopalan
> On Oct. 3, 2012, 11:50 a.m., namit jain wrote: > > Some questions: > > > > How much this interact with hive.stats.reliable ? > > > > There are many places with a TODO > > The formatting needs to be fixed in many places. > > Some functions are returning hashset etc. - they should be changed to

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-03 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/#review12133 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCompute

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-03 Thread namit jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/#review12131 --- Some questions: How much this interact with hive.stats.reliable ? T

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-02 Thread Shreepadma Venugopalan
> On Sept. 13, 2012, 9:58 p.m., Carl Steinbach wrote: > > Made it most of the way through the first page of the review. More comments > > to follow. Since Hive doesn't interpret binary data, I was using string data for testing. However as you suggest in the comment below, I'll be use the table

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-10-02 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/ --- (Updated Oct. 3, 2012, 3:10 a.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-1362: Support for column statistics in Hive

2012-09-13 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/#review11502 --- Made it most of the way through the first page of the review. More co

Review Request: HIVE-1362: Support for column statistics in Hive

2012-08-31 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6878/ --- Review request for hive and Carl Steinbach. Description --- This patch impl