Re: Review Request: HIVE-2573: create per-session function registry

2011-11-15 Thread Navis Ryu
> On 2011-11-15 22:41:17, Carl Steinbach wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 1232 > > > > > > Please don't move blocks of code around. It makes the diffs much harder > > to

Re: Review Request: HIVE-2573: create per-session function registry

2011-11-15 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2831/#review3281 --- Looks good overall, but I think we should continue to require that the

Re: Review Request: HIVE-2573: create per-session function registry

2011-11-14 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2831/ --- (Updated 2011-11-15 07:06:04.002057) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-2573: create per-session function registry

2011-11-14 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2831/ --- (Updated 2011-11-15 02:14:32.702033) Review request for hive and Carl Steinbach.

Review Request: HIVE-2573: create per-session function registry

2011-11-14 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2831/ --- Review request for hive and Carl Steinbach. Summary --- Extension from HIVE