Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-15 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/ --- Review request for hive and Carl Steinbach. Description --- This patch impl

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-19 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10517 --- The major thing missing at this point is a testcase. Since this a com

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-19 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10520 --- A couple more requests: * Can you please add a link to this review i

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-19 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10521 --- Also, is the DN upgrade still necessary now that you're no longer try

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-21 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/ --- (Updated Aug. 22, 2012, 2:48 a.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-21 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10555 --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaTool.jav

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-21 Thread Shreepadma Venugopalan
> On Aug. 20, 2012, 1:20 a.m., Carl Steinbach wrote: > > Also, is the DN upgrade still necessary now that you're no longer trying to > > use JDOQL's batch update feature? No. DN upgrade is not needed. I'll revert back to 2.0.3 in this patch. - Shreepadma

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-22 Thread namit jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10616 --- TestHiveMetaTool.launch

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-22 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10629 --- TestHiveMetaTool.launch

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-23 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/ --- (Updated Aug. 23, 2012, 8:19 p.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-23 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/ --- (Updated Aug. 23, 2012, 11:49 p.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-25 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/ --- (Updated Aug. 25, 2012, 8:56 p.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-25 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/ --- (Updated Aug. 25, 2012, 9 p.m.) Review request for hive and Carl Steinbach. De

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-25 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10764 --- conf/hive-default.xml.template

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-25 Thread Carl Steinbach
> On Aug. 22, 2012, 10:51 a.m., namit jain wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, line > > 3903 > > > > > > Is this a good idea ? > > > > Adding some API's in ObjectS

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-25 Thread Carl Steinbach
> On Aug. 26, 2012, 3:48 a.m., Carl Steinbach wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java, > > line 133 > > > > > > Please use e.getLocalizedMessage() instead. Also, it's gene

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-28 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/ --- (Updated Aug. 29, 2012, 3:24 a.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-28 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10790 --- metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-29 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10836 --- metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-29 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10837 --- metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-30 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10848 --- metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-08-31 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/#review10935 --- metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java

Re: Review Request: HIVE-3056: Ability to bulk update location field in Db/Table/Partition records

2012-09-03 Thread Shreepadma Venugopalan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6650/ --- (Updated Sept. 3, 2012, 4:29 p.m.) Review request for hive and Carl Steinbach.