Re: Review Request: review board for HIVE-2093

2011-04-21 Thread Siying Dong
On 2011-04-21 07:41:22, Carl Steinbach wrote: trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 2080 https://reviews.apache.org/r/566/diff/3/?file=15972#file15972line2080 Same deal here. Can you change this to return a boolean value? I'm going to follow convention

Re: Review Request: review board for HIVE-2093

2011-04-21 Thread Siying Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/566/ --- (Updated 2011-04-21 22:21:03.518662) Review request for hive, Yongqiang He and

Re: Review Request: review board for HIVE-2093

2011-04-19 Thread Siying Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/566/ --- (Updated 2011-04-19 19:25:22.632716) Review request for hive, Yongqiang He and

Re: Review Request: review board for HIVE-2093

2011-04-08 Thread Siying Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/566/ --- (Updated 2011-04-08 07:19:12.088932) Review request for hive, Yongqiang He and

Review Request: review board for HIVE-2093

2011-04-07 Thread Siying Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/566/ --- Review request for hive, Yongqiang He and namit jain. Summary --- Still