Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-04-04 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/#review39522 --- service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServic

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-03-12 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/#review36906 --- service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServic

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-03-10 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/ --- (Updated March 10, 2014, 6:39 p.m.) Review request for hive, Brock Noland, Carl

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-03-07 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/#review36539 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-03-07 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/#review36524 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-03-04 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/ --- (Updated March 4, 2014, 10:47 p.m.) Review request for hive, Brock Noland, Carl

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-03-04 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/ --- (Updated March 4, 2014, 8:06 a.m.) Review request for hive, Brock Noland, Carl

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-03-03 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/#review36000 --- shims/common-secure/src/main/java/org/apache/hadoop/hive/shims/Hado

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-03-03 Thread Prasad Mujumdar
> On Feb. 23, 2014, 9:47 a.m., Lefty Leverenz wrote: > > conf/hive-default.xml.template, line 2111 > > > > > > Agreed on both points. But as typos go, "requestion" is such a lovely > > word that it ought to be added

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-03-03 Thread Prasad Mujumdar
> On Jan. 8, 2014, 9:43 p.m., Thejas Nair wrote: > > beeline/src/java/org/apache/hive/beeline/BeeLine.java, line 547 > > > > > > we should document what this option means, in the usage output, and > > that it is a hiv

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-02-23 Thread Lefty Leverenz
> On Feb. 23, 2014, 9:47 a.m., Lefty Leverenz wrote: > > conf/hive-default.xml.template, line 2111 > > > > > > Agreed on both points. But as typos go, "requestion" is such a lovely > > word that it ought to be added

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-02-23 Thread Lefty Leverenz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/#review35241 --- conf/hive-default.xml.template

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-01-08 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/#review31384 --- beeline/src/java/org/apache/hive/beeline/BeeLine.java

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2013-12-05 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/ --- (Updated Dec. 5, 2013, 8:08 p.m.) Review request for hive, Brock Noland, Carl S

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2013-12-05 Thread Prasad Mujumdar
> On Dec. 5, 2013, 12:48 a.m., Carl Steinbach wrote: > > service/if/TCLIService.thrift, line 1041 > > > > > > Comment out of sync with code. Updated the comment > On Dec. 5, 2013, 12:48 a.m., Carl Steinbach wrote:

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2013-12-05 Thread Prasad Mujumdar
> On Dec. 4, 2013, 10:26 p.m., Brock Noland wrote: > > service/src/test/org/apache/hive/service/cli/session/TestSessionHooks.java, > > line 91 > > > > > > We should verify the hook ran, correct? yes, since the test re

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2013-12-04 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/#review26525 --- Here's what I caught on a first pass. service/src/java/org/apache

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2013-12-04 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/#review29764 --- I have looked at this before and it looks good to me! There are a co

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2013-12-04 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/ --- (Updated Dec. 4, 2013, 8:13 p.m.) Review request for hive, Brock Noland, Carl S

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2013-09-10 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/ --- (Updated Sept. 11, 2013, 3:55 a.m.) Review request for hive. Changes ---

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2013-09-10 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/ --- (Updated Sept. 11, 2013, 3:56 a.m.) Review request for hive and Carl Steinbach.

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2013-09-10 Thread Prasad Mujumdar
> On Sept. 10, 2013, 7:08 a.m., Carl Steinbach wrote: > > service/if/TCLIService.thrift, line 970 > > > > > > I know this is superficial, but can you please fix the formatting? This > > stuff drives me crazy. Thanks!

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2013-09-10 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/#review26013 --- service/if/TCLIService.thrift

Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2013-08-27 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13845/ --- Review request for hive. Bugs: HIVE-5155 https://issues.apache.org/jira/bro