Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-12-16 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Dec. 17, 2013, 5:34 a.m.) Review request for hive, Carl Steinbach,

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-12-04 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Dec. 5, 2013, 12:16 a.m.) Review request for hive, Carl Steinbach,

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-15 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/#review28948 --- service/if/TCLIService.thrift

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-15 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/#review28949 --- service/if/TCLIService.thrift

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-15 Thread Vaibhav Gumashta
On Nov. 15, 2013, 9:02 a.m., Carl Steinbach wrote: service/if/TCLIService.thrift, line 491 https://reviews.apache.org/r/15151/diff/5/?file=383817#file383817line491 Please bump this to V5. Also, does the V5 client now make any assumptions about the server being V5 too? Do we need

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-15 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Nov. 15, 2013, 7:59 p.m.) Review request for hive, Carl Steinbach,

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-15 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Nov. 15, 2013, 8 p.m.) Review request for hive, Carl Steinbach,

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-15 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Nov. 15, 2013, 7:59 p.m.) Review request for hive, Carl Steinbach,

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-15 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Nov. 15, 2013, 8:02 p.m.) Review request for hive, Carl Steinbach,

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-13 Thread Vaibhav Gumashta
On Nov. 11, 2013, 7:52 p.m., Carl Steinbach wrote: service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java, line 307 https://reviews.apache.org/r/15151/diff/3/?file=381921#file381921line307 Todo: set the status information. Vaibhav Gumashta wrote:

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-13 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Nov. 13, 2013, 9:54 p.m.) Review request for hive, Carl Steinbach,

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-13 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Nov. 13, 2013, 9:54 p.m.) Review request for hive, Carl Steinbach,

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-12 Thread Vaibhav Gumashta
On Nov. 11, 2013, 7:52 p.m., Carl Steinbach wrote: service/if/TCLIService.thrift, line 395 https://reviews.apache.org/r/15151/diff/3/?file=381909#file381909line395 Please reuse TStatus instead of adding a new struct. My understanding is that TStatus encapsulates the status of an

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-12 Thread Vaibhav Gumashta
On Nov. 11, 2013, 7:54 p.m., Thejas Nair wrote: service/if/TCLIService.thrift, line 917 https://reviews.apache.org/r/15151/diff/4/?file=382149#file382149line917 This will not be backward compatible. It would be better to add a new optional field in the response, that has the

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-12 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Nov. 12, 2013, 11:06 p.m.) Review request for hive, Carl Steinbach,

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-11 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Nov. 11, 2013, 9:49 a.m.) Review request for hive, Prasad Mujumdar

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-11 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Nov. 11, 2013, 10:57 a.m.) Review request for hive, Prasad Mujumdar

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-11 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Nov. 11, 2013, 7:23 p.m.) Review request for hive, Prasad Mujumdar

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-11 Thread Vaibhav Gumashta
On Nov. 8, 2013, 8:33 p.m., Prasad Mujumdar wrote: @Vaibhav, thanks for taking the issue forward and putting a new patch! I do have a high level comment on the approach. The 'status' returned by HS2 RPC is suppose to be the status of that particular API's execution. Where as in

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-11 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/#review28677 ---

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-11 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/#review28683 --- service/if/TCLIService.thrift

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-08 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/#review28572 --- @Vaibhav, thanks for taking the issue forward and putting a new

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-07 Thread Vaibhav Gumashta
On Nov. 5, 2013, 3:32 a.m., Thejas Nair wrote: service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java, line 70 https://reviews.apache.org/r/15151/diff/1/?file=375372#file375372line70 This and some other variables used by async execution needs to be made

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-06 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/#review28348 ---

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-06 Thread Thejas Nair
On Nov. 5, 2013, 3:32 a.m., Thejas Nair wrote: service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java, line 70 https://reviews.apache.org/r/15151/diff/1/?file=375372#file375372line70 This and some other variables used by async execution needs to be made

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-05 Thread Vaibhav Gumashta
On Nov. 5, 2013, 3:32 a.m., Thejas Nair wrote: service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java, line 70 https://reviews.apache.org/r/15151/diff/1/?file=375372#file375372line70 This and some other variables used by async execution needs to be made

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-04 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/#review28168 ---

Review Request 15151: Better error reporting by async threads in HiveServer2

2013-10-31 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- Review request for hive and Thejas Nair. Bugs: HIVE-5230

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-10-31 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Nov. 1, 2013, 12:54 a.m.) Review request for hive, Prasad Mujumdar