Re: Review Request 16053: HIVE-5966: Fix eclipse:eclipse post shim aggregation changes

2013-12-05 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16053/#review29868 --- Ship it! Ship It! - Brock Noland On Dec. 6, 2013, 2:13 a.m., Sze

Re: Review Request 16053: HIVE-5966: Fix eclipse:eclipse post shim aggregation changes

2013-12-05 Thread Brock Noland
> On Dec. 5, 2013, 11:36 p.m., Brock Noland wrote: > > "The hive projects are already declaring explicit compile-time dependencies > > to shims-version dependencies. (In fact, maybe we don't even need > > dependency from shims-aggregator to shims-version?)" > > > > Which projects? I see this

Re: Review Request 16053: HIVE-5966: Fix eclipse:eclipse post shim aggregation changes

2013-12-05 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16053/ --- (Updated Dec. 6, 2013, 2:13 a.m.) Review request for hive. Changes --- M

Re: Review Request 16053: HIVE-5966: Fix eclipse:eclipse post shim aggregation changes

2013-12-05 Thread Szehon Ho
> On Dec. 5, 2013, 11:36 p.m., Brock Noland wrote: > > "The hive projects are already declaring explicit compile-time dependencies > > to shims-version dependencies. (In fact, maybe we don't even need > > dependency from shims-aggregator to shims-version?)" > > > > Which projects? I see this

Re: Review Request 16053: HIVE-5966: Fix eclipse:eclipse post shim aggregation changes

2013-12-05 Thread Szehon Ho
> On Dec. 5, 2013, 11:36 p.m., Brock Noland wrote: > > "The hive projects are already declaring explicit compile-time dependencies > > to shims-version dependencies. (In fact, maybe we don't even need > > dependency from shims-aggregator to shims-version?)" > > > > Which projects? I see this

Re: Review Request 16053: HIVE-5966: Fix eclipse:eclipse post shim aggregation changes

2013-12-05 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16053/#review29849 --- "The hive projects are already declaring explicit compile-time depen

Review Request 16053: HIVE-5966: Fix eclipse:eclipse post shim aggregation changes

2013-12-05 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16053/ --- Review request for hive. Bugs: HIVE-5966 https://issues.apache.org/jira/bro