Re: Review Request 16910: HIVE-6173: Beeline doesn't accept --hiveconf option as Hive CLI does

2014-01-31 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16910/#review33327 --- Ship it! Ship It! beeline/src/java/org/apache/hive/beeline/BeeLin

Re: Review Request 16910: HIVE-6173: Beeline doesn't accept --hiveconf option as Hive CLI does

2014-01-30 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16910/#review33275 --- Ship it! Looks fine to me. - Prasad Mujumdar On Jan. 30, 2014, 1

Re: Review Request 16910: HIVE-6173: Beeline doesn't accept --hiveconf option as Hive CLI does

2014-01-30 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16910/ --- (Updated Jan. 30, 2014, 10:28 p.m.) Review request for hive. Bugs: HIVE-6173

Re: Review Request 16910: HIVE-6173: Beeline doesn't accept --hiveconf option as Hive CLI does

2014-01-15 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16910/#review31892 --- The patch itself look fine. Though I think it's not covering the cas

Re: Review Request 16910: HIVE-6173: Beeline doesn't accept --hiveconf option as Hive CLI does

2014-01-15 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16910/ --- (Updated Jan. 15, 2014, 5:43 p.m.) Review request for hive. Bugs: HIVE-6173

Review Request 16910: HIVE-6173: Beeline doesn't accept --hiveconf option as Hive CLI does

2014-01-15 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16910/ --- Review request for hive. Bugs: HIVE-6173 https://issues.apache.org/jira/bro