Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-28 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17005/ --- (Updated Jan. 28, 2014, 8:48 p.m.) Review request for hive and Eric Hanson. B

Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-28 Thread Eric Hanson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17005/#review33024 --- ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java

Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-27 Thread Jitendra Pandey
> On Jan. 27, 2014, 6:54 p.m., Eric Hanson wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java, line > > 1126 > > > > > > For safety, you could put a check here and throw an exception if >

Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-27 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17005/ --- (Updated Jan. 27, 2014, 11:20 p.m.) Review request for hive and Eric Hanson.

Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-27 Thread Eric Hanson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17005/#review32855 --- Please see my comment about the scale. Otherwise, it looks good to

Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-24 Thread Jitendra Pandey
> On Jan. 20, 2014, 6:56 p.m., Eric Hanson wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java, line > > 1119 > > > > > > It seems odd that we're reading from a scaleStream because the scale

Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-24 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17005/ --- (Updated Jan. 24, 2014, 10:28 p.m.) Review request for hive and Eric Hanson.

Re: Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-20 Thread Eric Hanson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17005/#review32299 --- common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java

Review Request 17005: Vectorized reader for DECIMAL datatype for ORC format.

2014-01-16 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17005/ --- Review request for hive and Eric Hanson. Bugs: HIVE-6178 https://issues.apa