Re: Review Request 17737: Add DECIMAL support to vectorized group by operator

2014-02-12 Thread Remus Rusanu
> On Feb. 10, 2014, 9:58 p.m., Jitendra Pandey wrote: > > ql/src/gen/vectorization/UDAFTemplates/VectorUDAFMinMaxDecimal.txt, line 53 > > > > > > Should we initialize isNull to true? It seems it will always be false >

Re: Review Request 17737: Add DECIMAL support to vectorized group by operator

2014-02-10 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17737/#review33964 --- common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.j

Re: Review Request 17737: Add DECIMAL support to vectorized group by operator

2014-02-05 Thread Remus Rusanu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17737/ --- (Updated Feb. 5, 2014, 11:04 a.m.) Review request for hive, Eric Hanson and Jit

Review Request 17737: Add DECIMAL support to vectorized group by operator

2014-02-05 Thread Remus Rusanu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17737/ --- Review request for hive, Eric Hanson and Jitendra Pandey. Bugs: HIVE-6344 h