Re: Review Request 17930: HIVE-6402: Improve Hive behavior when deleting data with miss configured Trash

2014-02-11 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17930/#review34206 ---

Re: Review Request 17930: HIVE-6402: Improve Hive behavior when deleting data with miss configured Trash

2014-02-11 Thread Szehon Ho
On Feb. 11, 2014, 2:35 a.m., Mohammad Islam wrote: metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 866 https://reviews.apache.org/r/17930/diff/1/?file=482265#file482265line866 adding dataSuccess is required here? Thanks, fixed all instances of

Re: Review Request 17930: HIVE-6402: Improve Hive behavior when deleting data with miss configured Trash

2014-02-11 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17930/ --- (Updated Feb. 11, 2014, 7:03 p.m.) Review request for hive. Changes ---

Re: Review Request 17930: HIVE-6402: Improve Hive behavior when deleting data with miss configured Trash

2014-02-11 Thread Szehon Ho
On Feb. 11, 2014, 5:42 p.m., Xuefu Zhang wrote: metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 879 https://reviews.apache.org/r/17930/diff/1/?file=482265#file482265line879 It seems interesting to know what's the impact of throwing an exception

Review Request 17930: HIVE-6402: Improve Hive behavior when deleting data with miss configured Trash

2014-02-10 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17930/ --- Review request for hive. Bugs: HIVE-6402

Re: Review Request 17930: HIVE-6402: Improve Hive behavior when deleting data with miss configured Trash

2014-02-10 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17930/#review34163 --- Looks good with simple comments.