Re: Review Request 23373: HIVE-6252: sql std auth - support 'with admin option' in revoke role metastore api

2014-07-10 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23373/#review47565 --- metastore/if/hive_metastore.thrift

Re: Review Request 23373: HIVE-6252: sql std auth - support 'with admin option' in revoke role metastore api

2014-07-10 Thread Jason Dere
On July 10, 2014, 6:05 p.m., Thejas Nair wrote: metastore/if/hive_metastore.thrift, line 178 https://reviews.apache.org/r/23373/diff/1-2/?file=627078#file627078line178 Making these fields optional can be confusing for external users. Should we just update this unit test to set

Re: Review Request 23373: HIVE-6252: sql std auth - support 'with admin option' in revoke role metastore api

2014-07-10 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23373/ --- (Updated July 10, 2014, 9:20 p.m.) Review request for hive and Thejas Nair.

Re: Review Request 23373: HIVE-6252: sql std auth - support 'with admin option' in revoke role metastore api

2014-07-10 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23373/#review47624 --- Ship it! Ship It! - Thejas Nair On July 10, 2014, 9:20 p.m.,

Review Request 23373: HIVE-6252: sql std auth - support 'with admin option' in revoke role metastore api

2014-07-09 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23373/ --- Review request for hive and Thejas Nair. Bugs: HIVE-6252

Re: Review Request 23373: HIVE-6252: sql std auth - support 'with admin option' in revoke role metastore api

2014-07-09 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23373/#review47527 --- ql/src/test/queries/clientnegative/authorization_role_grant2.q

Re: Review Request 23373: HIVE-6252: sql std auth - support 'with admin option' in revoke role metastore api

2014-07-09 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23373/#review47543 --- - Jason Dere On July 9, 2014, 7:02 p.m., Jason Dere wrote:

Re: Review Request 23373: HIVE-6252: sql std auth - support 'with admin option' in revoke role metastore api

2014-07-09 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23373/ --- (Updated July 10, 2014, 2:53 a.m.) Review request for hive and Thejas Nair.

Re: Review Request 23373: HIVE-6252: sql std auth - support 'with admin option' in revoke role metastore api

2014-07-09 Thread Jason Dere
On July 9, 2014, 10:13 p.m., Thejas Nair wrote: ql/src/test/queries/clientnegative/authorization_role_grant2.q, line 24 https://reviews.apache.org/r/23373/diff/1/?file=627091#file627091line24 set role admin; is needed here The revoke is not succeeding (in q.out) because of

Re: Review Request 23373: HIVE-6252: sql std auth - support 'with admin option' in revoke role metastore api

2014-07-09 Thread Jason Dere
- Jason --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23373/#review47527 --- On July 10, 2014, 2:53 a.m., Jason Dere wrote: