Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-09-08 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/#review52606 ---

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-09-06 Thread Na Yang
On Sept. 5, 2014, 8:17 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java, line 1747 https://reviews.apache.org/r/25176/diff/4/?file=676862#file676862line1747 The if condition already checks fileSinkDesc.isLinkedFileSink(), how come in

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-09-06 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/#review52554 ---

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-09-06 Thread Na Yang
On Sept. 7, 2014, 4:46 a.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java, line 1749 https://reviews.apache.org/r/25176/diff/4/?file=676862#file676862line1749 sorry for my curiosity. If the dir is the same, wouldn't data overwrites

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-09-05 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/#review52498 ---

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-09-04 Thread Na Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/ --- (Updated Sept. 4, 2014, 5:03 p.m.) Review request for hive, Brock Noland,

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-09-04 Thread Na Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/ --- (Updated Sept. 4, 2014, 5:03 p.m.) Review request for hive, Brock Noland,

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-09-03 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/#review52271 --- Thank you for the update Na! I have a couple minor comments and

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-09-02 Thread Na Yang
On Aug. 29, 2014, 5:30 p.m., Brock Noland wrote: Hi Na, Thank you very much for the patch! I have one high level question: It appears we created the union_remove_spark* files because we wanted to add an additional property to the union_remove .q file? Meaning what is the delta

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-08-29 Thread Na Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/ --- (Updated Aug. 29, 2014, 6:44 a.m.) Review request for hive, Brock Noland,

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-08-29 Thread Na Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/ --- (Updated Aug. 29, 2014, 6:44 a.m.) Review request for hive, Brock Noland,

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-08-29 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/#review51889 --- Hi Na, Thank you very much for the patch! I have one high level

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-08-29 Thread Na Yang
On Aug. 29, 2014, 5:30 p.m., Brock Noland wrote: Hi Na, Thank you very much for the patch! I have one high level question: It appears we created the union_remove_spark* files because we wanted to add an additional property to the union_remove .q file? Meaning what is the delta

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-08-29 Thread Brock Noland
On Aug. 29, 2014, 5:30 p.m., Brock Noland wrote: Hi Na, Thank you very much for the patch! I have one high level question: It appears we created the union_remove_spark* files because we wanted to add an additional property to the union_remove .q file? Meaning what is the delta

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-08-29 Thread Na Yang
On Aug. 29, 2014, 5:30 p.m., Brock Noland wrote: Hi Na, Thank you very much for the patch! I have one high level question: It appears we created the union_remove_spark* files because we wanted to add an additional property to the union_remove .q file? Meaning what is the delta

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-08-29 Thread Brock Noland
On Aug. 29, 2014, 5:30 p.m., Brock Noland wrote: Hi Na, Thank you very much for the patch! I have one high level question: It appears we created the union_remove_spark* files because we wanted to add an additional property to the union_remove .q file? Meaning what is the delta

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-08-29 Thread Na Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/ --- (Updated Aug. 29, 2014, 8:59 p.m.) Review request for hive, Brock Noland,

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-08-29 Thread Na Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/ --- (Updated Aug. 29, 2014, 8:59 p.m.) Review request for hive, Brock Noland,

Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-08-28 Thread Na Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/ --- Review request for hive, Brock Noland, Szehon Ho, and Xuefu Zhang. Bugs:

Re: Review Request 25176: HIVE-7870: Insert overwrite table query does not generate correct task plan [Spark Branch]

2014-08-28 Thread Na Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25176/ --- (Updated Aug. 28, 2014, 11:42 p.m.) Review request for hive, Brock Noland,