Re: Review Request 25329: HIVE-7932: It may cause NP exception when add accessed columns to ReadEntity

2014-09-16 Thread Xiaomeng Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25329/ --- (Updated Sept. 16, 2014, 6:08 a.m.) Review request for hive, Brock Noland,

Re: Review Request 25329: HIVE-7932: It may cause NP exception when add accessed columns to ReadEntity

2014-09-15 Thread Xiaomeng Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25329/ --- (Updated Sept. 15, 2014, 11:29 a.m.) Review request for hive, Brock Noland,

Re: Review Request 25329: HIVE-7932: It may cause NP exception when add accessed columns to ReadEntity

2014-09-15 Thread Xiaomeng Huang
On Sept. 16, 2014, 4:18 a.m., cheng xu wrote: ql/src/test/org/apache/hadoop/hive/ql/parse/TestColumnAccess.java, line 1 https://reviews.apache.org/r/25329/diff/2/?file=689279#file689279line1 Just a suggestion, you can use query test instead of unit test to avoid some many assert

Re: Review Request 25329: HIVE-7932: It may cause NP exception when add accessed columns to ReadEntity

2014-09-15 Thread Xiaomeng Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25329/ --- (Updated Sept. 16, 2014, 5:48 a.m.) Review request for hive, Brock Noland,

Review Request 25329: HIVE-7932: It may cause NP exception when add accessed columns to ReadEntity

2014-09-04 Thread Xiaomeng Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25329/ --- Review request for hive, Brock Noland, Prasad Mujumdar, and Szehon Ho.